fix: correct isArchived to is_archived in ViewCampaign.vue#431
Open
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Open
fix: correct isArchived to is_archived in ViewCampaign.vue#431MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Conversation
The backend uses snake_case (is_archived), but the frontend was using camelCase (isArchived), causing incorrect UI state. Fixes: incorrect campaign archive status handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Two broken behaviours in the campaign view:
Root cause
Lines 44 and 75 of ViewCampaign.vue use
campaign.isArchived(camelCase). The API returnsis_archived(snake_case). Looking up a camelCase key on a plain JS object returnsundefined, which is falsy. So::disabled="campaign.isArchived"→ always false → button always enabledv-if="!campaign.isArchived"→ always true → Cancel always visibleFix
Changed both occurrences from
campaign.isArchived→campaign.is_archived.Files changed
frontend/src/components/Campaign/ViewCampaign.vueHow to verify
Relates to: T415578