fix: add missing disabled binding to Close Campaign button#432
Open
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Open
fix: add missing disabled binding to Close Campaign button#432MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
MuraariK13052008 wants to merge 1 commit intohatnote:masterfrom
Conversation
The button was always enabled because :disabled binding was missing. Now correctly reflects canCloseCampaign state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The "Close Campaign" button was always clickable regardless of whether the campaign was actually active.
Root cause
canCloseCampaignis a reactive ref that is correctly set totrueonly whencampaign.status === 'active'insidereloadState(). However, the Close Campaign button in the template had no:disabledbinding at all — the ref was declared and populated but never consumed in the template, making the button permanently enabled.Fix
Added
:disabled="!canCloseCampaign"to the Close Campaign button on line 7 of ViewCampaign.vue.Files changed
frontend/src/components/Campaign/ViewCampaign.vueHow to verify
Relates to: T415578