[ruby] Optimise Architecture of App#124
Merged
hayat01sh1da merged 3 commits intoJul 4, 2026
Merged
Conversation
Satisfies Style/Documentation for the sub-app test directories, which fall outside RuboCop's default top-level test exclusion. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
88385dd to
2b58093
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Overview
This PR removes the only RuboCop override in
ruby/.rubocop.ymland completes the project's RBS inline coverage.The config excluded
**/test/**/*fromStyle/Documentationbecause the sub-app test directories (e.g.fizzbuzz/test/) are not matched by RuboCop's default top-leveltest/**/*exclusion, so six test classes were flagged as missing top-level documentation.Instead of keeping the exclusion, each of the six test classes now carries a one-line documentation comment, and the one test file that lacked the
# rbs_inline: enabledmagic comment (letter_matching_inspection/test/application_test.rb) received it, so every test file now participates in signature generation.2. Key Changes & Differences
ruby/.rubocop.ymlStyle/Documentation: Exclude: '**/test/**/*'AllCopsonlyruby/**/test/*_test.rbfilesStyle/Documentationin code.ruby/letter_matching_inspection/test/application_test.rb# rbs_inline: enabledmagic commentruby/sig/generated/**letter_matching_inspection/test/application_test.rbsgenerated for the first time; five test sigs refreshedrbs-inline --output sig/generated/ ..3. Summary
Comment-only changes plus regenerated signatures; no runtime behaviour is affected.
Verified with RuboCop 1.88.1 (
16 files inspected, no offenses detected) and rbs-inline 0.14.0 regeneration.Branch commits (newest first):
4fad39dArticulate RBS inline types and regenerate signatures2b58093Remove Style/Documentation RuboCop patch12de45dAdd documentation comments to test classes4. References