Skip to content

Undo find typing#21

Merged
n1kolasM merged 11 commits into
masterfrom
undo_find_typing
Oct 6, 2025
Merged

Undo find typing#21
n1kolasM merged 11 commits into
masterfrom
undo_find_typing

Conversation

@n1kolasM

Copy link
Copy Markdown

No description provided.

Nikolay Marchuk and others added 11 commits September 29, 2025 20:33
There are no other meaningful types to deserialize into because inner
type depends on other event params
Rust sometimes can't detect that query_pairs_mut dropped before .await
and makes whole feature !Send, using additional inner scope fixes it
Signed-off-by: Alexey Aristov <aav@acm.org>
@n1kolasM n1kolasM requested review from aav and Copilot September 30, 2025 12:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes generic type constraints from transaction documents, specifically undoing the typing requirements for find operations and remove documents. The changes make these operations work with runtime class information rather than compile-time generic types.

  • Removes generic type parameters from TxRemoveDoc and related structures
  • Updates find_all and find_one methods to accept class names as string parameters
  • Modifies event matching logic to rely solely on class field matching

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/services/transactor/subscription.rs Updates event handling to use non-generic TxRemoveDoc and adds runtime class validation
src/services/transactor/mod.rs Modifies remove operation to explicitly set object_class field
src/services/transactor/document.rs Removes generic constraints from RemoveDocument and updates find methods to accept class strings
src/services/transactor/comm/message.rs Changes default MessageType from "Message" to "Text"
src/services/transactor/backend/http.rs Refactors query parameter building with proper scoping
src/services/core/tx.rs Removes generic type parameters from TxRemoveDoc and simplifies event matching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/services/transactor/document.rs
Comment thread src/services/transactor/subscription.rs
Comment thread src/services/transactor/backend/http.rs
@n1kolasM n1kolasM merged commit 408a7e7 into master Oct 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants