Use the numpy dtype in get_type if the array is empty#318
Open
Use the numpy dtype in get_type if the array is empty#318
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #318 +/- ##
==========================================
- Coverage 72.74% 72.72% -0.03%
==========================================
Files 33 33
Lines 6436 6438 +2
Branches 1409 1410 +1
==========================================
Hits 4682 4682
- Misses 1327 1328 +1
- Partials 427 428 +1
Continue to review full report at Codecov.
|
rly
approved these changes
Jun 24, 2020
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix issue identified in oruebel/ndx-icephys-meta#57 with validating empty datasets. This is triggered in the icephys extension because it may use an empty DynamicTable (with just and id column) resulting in an empty columns dataset.
How to test the behavior?
See oruebel/ndx-icephys-meta#57 (comment)
Checklist
flake8from the source directory.#XXXnotation whereXXXis the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.