chore(release): 0.10.0 - #68
Merged
Merged
Conversation
Minor: get_events now returns EventTimes rather than a plain dict, and OpenRocketInstance/SimulationPool gained profile_exact. Both are the same property from two sides. A caller could not tell "this simulation had no such event" from "orlab did not recognise the event", nor "this is the profile for your jar" from "this is the nearest older one". Neither is visible in the published 0.9.0. EventTimes subclasses dict, so indexing and comparison are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump only;
pyproject.tomlwas already at0.10.0.dev0.Ships two halves of one property
Both are about a caller being able to tell "nothing was there" from "orlab could not tell
you", and neither is visible in the published 0.9.0:
OpenRocketInstance.profile_exact(The nearest-older profile fallback is log-only: no caller can branch on it #61) --Falsewhen orlab fell back to thenearest older profile because it does not know the jar's release. The fallback reached
the caller only as a log line, which an application can silence.
EventTimes.unknown_event_types(get_events silently drops unknown event types: the returned dict looks complete #63) -- the Java event-type namesget_eventscould not interpret. The returned mapping looked complete; a caller iterating it could
not tell a simulation with no such event from one whose event orlab dropped.
The second is likeliest exactly when the first is
False-- a newer OpenRocket on anolder profile is where unknown event types appear -- so they belong in one release.
Compatibility
EventTimessubclassesdict, so indexing,==against a plain dict anddict(events)all behave as before; that is asserted. Existing callers see no change.
just checkandjust testgreen: 235 passed, 2 skipped.