[TASK] Add PHP 8.4 support via Rector #61
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritz-ngo
commented
May 30, 2025
Contributor
Author
There was a problem hiding this comment.
$ ddev typo3 cache:flush -v
PHP Warning: file_get_contents(/composer.json): Failed to open stream: No such file or directory in /var/www/html/vendor/helhum/typo3-config-handling/src/SettingsFiles.php on line 47
PHP Fatal error: Uncaught TypeError: json_decode(): Argument #1 ($json) must be of type string, false given in /var/www/html/vendor/helhum/typo3-config-handling/src/SettingsFiles.php:47
Stack trace:
#0 /var/www/html/vendor/helhum/typo3-config-handling/src/SettingsFiles.php(47): json_decode()
#1 /var/www/html/vendor/helhum/typo3-config-handling/src/SettingsFiles.php(11): Helhum\TYPO3\ConfigHandling\SettingsFiles::getComposerConfig()
#2 /var/www/html/vendor/helhum/typo3-config-handling/src/ConfigLoader.php(43): Helhum\TYPO3\ConfigHandling\SettingsFiles::getSettingsFile()
#3 /var/www/html/vendor/helhum/typo3-config-handling/src/Xclass/ConfigurationManager.php(136): Helhum\TYPO3\ConfigHandling\ConfigLoader->__construct()
#4 /var/www/html/vendor/typo3/cms-core/Classes/Core/Bootstrap.php(312): Helhum\TYPO3\ConfigHandling\Xclass\ConfigurationManager->__construct()
#5 /var/www/html/vendor/typo3/cms-core/Classes/Core/Bootstrap.php(85): TYPO3\CMS\Core\Core\Bootstrap::createConfigurationManager()
#6 /var/www/html/vendor/typo3/cms-cli/typo3(23): TYPO3\CMS\Core\Core\Bootstrap::init()
#7 /var/www/html/vendor/typo3/cms-cli/typo3(24): {closure:/var/www/html/vendor/typo3/cms-cli/typo3:20}()
#8 /var/www/html/vendor/bin/typo3(119): include('...')
#9 {main}
thrown in /var/www/html/vendor/helhum/typo3-config-handling/src/SettingsFiles.php on line 47
moritz-ngo
commented
May 30, 2025
Contributor
Author
There was a problem hiding this comment.
This file should be updated to be in line with the current version
moritz-ngo
force-pushed
the
main
branch
3 times, most recently
from
64f6813 to
779c9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should add support for PHP 8.4 and prevent any deprecation notices.
The changes were primarily made with Rector.