Default root_uri to the workspace #14755
Open
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows using JDT Language server the LSP would crash on opening a .java file in which it would not resolve a
rootpath when callingfind_lsp_workspace.This is because the JDT language server does not accept non URI paths on windows for example
C:\foo\barwhich is being passed by theroot_pathvariable.If we always set
root_uriwhen possible it will use that and get the correctly formatted file:// URI.To reproduce this issue on windows you just need to make create a java file anywhere it will not find the lsp workspace, for example
hx C:\tmp\main.javathen look at the log and see the below:I am not very familiar with the codebase so not sure of why we cant do this, just wanted to make a PR as it resolved my issue. Not sure about the implications on other OS's language servers.