Fix more errorlint warnings. Use errors.As and errors.Is for error handling.
#31667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
atombrella
changed the title
errors.As and errors.Is for error handling.
Use errors.As instead of type-casting, errors.Is for comparison and use of %w for error formatting in fmt.Errorf. The changes do not fully fix all of errorlint. I don't feel comfortable touching files under v1-3 as this may break compatibility with api users. Signed-off-by: Mads Jensen <[email protected]>
Signed-off-by: Mads Jensen <[email protected]>
atombrella
force-pushed
the
feature/errorlint_as_round_2
branch
from
b16ab16 to
711204d
Compare
atombrella
commented
Dec 20, 2025
| const warnStartDelim = "HELM_ERR_START" | ||
| const warnEndDelim = "HELM_ERR_END" | ||
| const recursionMaxNums = 1000 | ||
| const ( |
Contributor
Author
There was a problem hiding this comment.
Maybe this should be in a separate PR. Anyway, it's just a bit a syntactic sugar :)
atombrella
commented
Dec 20, 2025
atombrella
force-pushed
the
feature/errorlint_as_round_2
branch
from
6ec8cd9 to
711204d
Compare
TerryHowe
reviewed
Dec 20, 2025
atombrella
force-pushed
the
feature/errorlint_as_round_2
branch
from
18e7091 to
6ded2ff
Compare
Signed-off-by: Mads Jensen <[email protected]>
Signed-off-by: Mads Jensen <[email protected]>
atombrella
force-pushed
the
feature/errorlint_as_round_2
branch
from
6ded2ff to
e597f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use
errors.Asinstead of type-casting,errors.Isfor comparison and use of%wfor error formatting infmt.Errorf. The changes do not fully fix all of errorlint. I don't feel comfortable touching files under v1-3 as this may break compatibility with API users.I have not successfully been able to change the use of
switchwith comparison of the error type. There are a few instances of this:Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)