Improve NameRes memory and Solr cache configuration#1082
Open
gaurav wants to merge 5 commits into
Open
Conversation
The _default configset's 512-entry queryResultCache was badly undersized (~56% hit rate, 317K evictions) while filterCache was healthy. Tune it via the Config API during the restore job, configurable through values.yaml. See NCATSTranslator/NameResolution#266 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The young generation was pinned (-XX:NewSize/MaxNewSize=4G), which overrode the adaptive G1NewSizePercent bounds and disabled the MaxGCPauseMillis goal. Drop the pin so G1 sizes young gen against a 200ms pause target, let IHOP stay adaptive, and set -Xms == -Xmx to avoid runtime heap resizing. See NCATSTranslator/NameResolution#272 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heap_memand removed the minimum memory constraint (Reduce Solr JVM heap to leave room for OS page cache NCATSTranslator/NameResolution#265)queryResultCachefor NameRes, which was badly undersized (~56% hit rate, 317K evictions), now configurable viavalues.yaml(Grow queryResultCache (size=512, 56% hit rate, 317K evictions) NCATSTranslator/NameResolution#266)-Xms == -Xmxto avoid runtime heap resizing (Revisit Solr JVM GC flags: pinned young generation disables the G1 pause-time goal; collect GC logs under load NCATSTranslator/NameResolution#272)Test plan
🤖 Generated with Claude Code