fix(detect): ignore Cursor Run Everything status - #2220
Conversation
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChangesCursor detection
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Greptile SummaryThis PR narrows Cursor’s execution-approval detection so the persistent “Run Everything” footer remains idle while genuine
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/detect/manifests/cursor.toml | Narrows the bundled Cursor approval rule to distinguish active Run prompts from persistent Run Everything status text. |
| website/agent-detection/cursor.toml | Mirrors the bundled Cursor rule and metadata update in the published detection manifest. |
| src/detect/manifest/tests.rs | Adds focused coverage confirming genuine run approval remains blocked while footer and status variants remain idle. |
Reviews (2): Last reviewed commit: "fix(detect): constrain Cursor approval c..." | Re-trigger Greptile
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/detect/manifest/tests.rs (1)
303-330: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd a negative case for incidental approval text.
This test covers the real
→ Run (once) (y)prompt and fragmentedRun Everythingtext. It does not cover a non-control line that satisfies the new second regex alternative. Add a case such as(y) was selected; the command will allow executionand assertIdlewith no matched rule.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fd0b151b-8fb2-4bfa-b02b-0645a92d5eec
📒 Files selected for processing (3)
src/detect/manifest/tests.rssrc/detect/manifests/cursor.tomlwebsite/agent-detection/cursor.toml
|
@coderabbitai review |
✅ Action performedReview finished.
|
Fixes #1763.
Require
(y)on Cursor run-approval controls so the persistentRun Everythingfooter is not reported as blocked. Real→ Run (once) (y)prompts remain blocked, with regression coverage for wrapped footer variants.Validation: focused Cursor regression test, manifest checks, clippy, and 3027/3028 nextest tests passed. The remaining live-handoff test fails identically on clean
origin/master.