Skip to content

Conversation

@ZhuhongLee
Copy link

解决Oracle 19c 非CDB容器部署,生成回滚语句报不支持CONTINOUS_MINE的问题,若是CDB容器部署,暂不支持备份

@codecov
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.77%. Comparing base (5f556a5) to head (5e3b021).
⚠️ Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
sql/engines/oracle.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   76.82%   76.77%   -0.05%     
==========================================
  Files         117      117              
  Lines       16073    16083      +10     
==========================================
  Hits        12348    12348              
- Misses       3725     3735      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZhuhongLee ZhuhongLee requested a review from LeoQuote March 28, 2024 01:14
@ZhuhongLee ZhuhongLee marked this pull request as draft March 28, 2024 01:15
@LeoQuote
Copy link
Collaborator

lint 必须要过,自己用black再整理一下,覆盖率尽量达标

@LeoQuote
Copy link
Collaborator

Archery/sql/engines/tests.py

Lines 1447 to 1459 in 5f556a5

@patch("sql.engines.oracle.OracleEngine.query")
@patch("cx_Oracle.connect.cursor.execute")
@patch("cx_Oracle.connect.cursor")
@patch("cx_Oracle.connect")
def test_kill_session(self, _query, _connect, _cursor, _execute):
new_engine = OracleEngine(instance=self.ins)
_query.return_value.rows = (
("alter system kill session '12,123';",),
("alter system kill session '34,345';",),
)
_execute.return_value = ResultSet()
r = new_engine.kill_session([[12, 123], [34, 345]])
self.assertIsInstance(r, ResultSet)
你照着试试写一下测试

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants