generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 1
HDPI-2237: Review and confirm defendant names and property address #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewdami11
wants to merge
84
commits into
master
Choose a base branch
from
HDPI-2237-review-and-confirm-defendant-names-and-property-address
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,360
−71
Open
Changes from all commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
b087a89
HDPI-2510: Additional defendants
scottstewart-sl 3f3674c
Merge branch 'master' into HDPI-2510_defendant_details
scottstewart-sl 62f548b
HDPI-2510: Adding missing hint text for additional defendants
scottstewart-sl 5c2eaaf
HDPI-2510: Extract defendant validation into its own class
scottstewart-sl 1067f23
HDPI-2510: Only map additional defendants when indicated
scottstewart-sl 50e08de
HDPI-2510: Add a unit test to show that a null additionalDefendants l…
scottstewart-sl c6a99c2
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl 6020d20
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash d7d5c57
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash 705eb62
HDPI-2510: Persist whether the user selected to add additional defend…
scottstewart-sl c4c1a0d
Merge branch 'master' into HDPI-2510_defendant_details
scottstewart-sl 821e4b0
Merge branch 'master' into HDPI-2510_defendant_details
jessieharrigan 21a3753
Merge branch 'master' into HDPI-2510_defendant_details
jessieharrigan 2db15d9
Merge branch 'master' into HDPI-2510_defendant_details
jessieharrigan fc11227
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl 7ce0cf4
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash 6f02db8
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl dd33521
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash 814505f
feat: add domain models for eviction workflow
andrewdami11 0d48648
feat: add ChangeNameAddressPage error page
andrewdami11 1661902
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl eca7c48
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash e8fb03d
feat: add PeopleWhoWillBeEvictedPage and PeopleYouWantToEvictPage
andrewdami11 b105467
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash e0c8c57
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl 26eb7c8
feat: add mid-event callback to NameAndAddressForEvictionPage for con…
andrewdami11 f957c9c
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl d10b2af
HDPI-2510: Add custom error message for ExUI collections bug
scottstewart-sl 2b848c3
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash e033c0c
feat: integrate new eviction pages into EnforcementOrderEvent
andrewdami11 17c1a46
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl a40635e
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash bcccecd
test: add unit tests for eviction workflow pages
andrewdami11 1224b5e
fix: add missing VerticalYesNo import in PeopleWhoWillBeEvictedPage
andrewdami11 2c525e0
Merge branch 'master' into HDPI-2510_defendant_details
jessieharrigan 340b052
Merge remote-tracking branch 'origin/master' into HDPI-2510_defendant…
scottstewart-sl 45892fd
Merge branch 'HDPI-2510_defendant_details' into HDPI-2237-review-and-…
andrewdami11 d5c2d71
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash 35d3b22
Automation HDPI-2510 Add additional defendants (#801)
AshaJayaprakash 5c1d27f
refactor: use govuk class instead
andrewdami11 18e20a6
feat: add CCD annotations to nameAndAddressForEviction and peopleToEv…
andrewdami11 3b0d76f
refactor: use getFirst() instead
andrewdami11 ef3cd9e
refactor: make modelMapper variable final
andrewdami11 032f2d0
refactor: remove unused errors list from NameAndAddressForEvictionPage
andrewdami11 f630c38
refactor: simplify error handling in ChangeNameAddressPage
andrewdami11 259bb92
Merge branch 'master' into HDPI-2510_defendant_details
scottstewart-sl 487f28d
refactor: small JSDoc refactor
andrewdami11 11ae1c5
refactor: add JSDoc comments for defendant details in PCSCase
andrewdami11 97268a3
refactor: update label and hint for correct name and address in NameA…
andrewdami11 8000cc5
refactor: update page label in ChangeNameAddressPage
andrewdami11 b32c2d8
refactor: remove unused errors list from eviction-related pages
andrewdami11 f2729ff
refactor: replace integer codes with UUIDs for defendants in Defendan…
andrewdami11 a4f8ca4
refactor: use CollectionUtils.isEmpty() from Spring Framework
andrewdami11 0569738
refactor: streamline defendant data initialization and selection list…
andrewdami11 3332ce1
refactor: remove redundant show condition and related logic from Livi…
andrewdami11 f2083c6
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash 67da39e
refactor: update navigation logic for eviction pages to streamline us…
andrewdami11 0a2dc99
Merge branch 'master' into HDPI-2510_defendant_details
AshaJayaprakash 3f3361f
refactor: rename parameter in buildDefendantListItems method for clarity
andrewdami11 08a8caf
refactor: make populateDefendantSelectionList method package private …
andrewdami11 88decd7
Merge branch 'HDPI-2510_defendant_details' into HDPI-2237-review-and-…
andrewdami11 6771c9e
refactor: use CollectionUtils for null and empty check in buildDefend…
andrewdami11 d6420d8
Merge branch 'master' into HDPI-2510_defendant_details
scottstewart-sl 7c903fa
Merge branch 'HDPI-2510_defendant_details' into HDPI-2237-review-and-…
andrewdami11 0c23b4d
refactor: Remove unused field 'showLivingInThePropertyPage' from Enfo…
andrewdami11 19b50b5
test: Remove unused assertion for 'showLivingInThePropertyPage' in Dr…
andrewdami11 db1c649
Merge branch 'master' into HDPI-2237-review-and-confirm-defendant-nam…
andrewdami11 8e9325b
Merge branch 'master' into HDPI-2237-review-and-confirm-defendant-nam…
tvr-hmcts 6cefaa2
Merge branch 'master' into HDPI-2237-review-and-confirm-defendant-nam…
tvr-hmcts 646299e
Merge remote-tracking branch 'refs/remotes/origin/master' into HDPI-2…
tvr-solirius 955c33d
Merge remote-tracking branch 'refs/remotes/origin/master' into HDPI-2…
tvr-solirius f4776b5
HDPI-2237: Add defendant name formatting and adjust eviction page han…
tvr-solirius 3dc0f1f
Merge remote-tracking branch 'refs/remotes/origin/master' into HDPI-2…
tvr-solirius 3595cbc
HDPI-2237: Reorganize imports and update test dependencies in Enforce…
tvr-solirius 40b80a3
HDPI-2237: Remove unused readonly field from eviction page setup
tvr-solirius 8759f36
HDPI-2237: Simplify defendant name formatting and restructure evictio…
tvr-solirius 2787bb9
Merge remote-tracking branch 'refs/remotes/origin/master' into HDPI-2…
tvr-solirius 0fb45a7
HDPI-2237: Disable CaseDefinitionIT and fix formatting issues in enfo…
tvr-solirius 6466e2a
HDPI-2237: Re-enable CaseDefinitionIT test
tvr-solirius 040a600
Merge branch 'master' into HDPI-2237-review-and-confirm-defendant-nam…
cristianemarsilio b7e9916
Merge branch 'master' into HDPI-2237-review-and-confirm-defendant-nam…
andrewdami11 f59383e
fix: correctly check for non-empty defendants list
andrewdami11 abe4223
Merge branch 'master' into HDPI-2237-review-and-confirm-defendant-nam…
andrewdami11 d93c69c
Merge branch 'master' into HDPI-2237-review-and-confirm-defendant-nam…
andrewdami11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/main/java/uk/gov/hmcts/reform/pcs/ccd/domain/enforcement/PeopleToEvict.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package uk.gov.hmcts.reform.pcs.ccd.domain.enforcement; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Data; | ||
| import uk.gov.hmcts.ccd.sdk.api.CCD; | ||
| import uk.gov.hmcts.reform.pcs.ccd.domain.VerticalYesNo; | ||
|
|
||
| /** | ||
| * Domain model for the "people who will be evicted" page. | ||
| * Contains the selection for whether to evict everyone or specific people. | ||
| */ | ||
| @Builder | ||
| @Data | ||
| public class PeopleToEvict { | ||
|
|
||
| @CCD( | ||
| label = "Do you want to evict everyone at the property?", | ||
| hint = "This includes all of the defendants and anyone else living at the property" | ||
| ) | ||
| private VerticalYesNo evictEveryone; | ||
|
|
||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
src/main/java/uk/gov/hmcts/reform/pcs/ccd/page/enforcement/ChangeNameAddressPage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package uk.gov.hmcts.reform.pcs.ccd.page.enforcement; | ||
|
|
||
| import uk.gov.hmcts.ccd.sdk.api.CaseDetails; | ||
| import uk.gov.hmcts.ccd.sdk.api.callback.AboutToStartOrSubmitResponse; | ||
| import uk.gov.hmcts.reform.pcs.ccd.common.CcdPageConfiguration; | ||
| import uk.gov.hmcts.reform.pcs.ccd.common.PageBuilder; | ||
| import uk.gov.hmcts.reform.pcs.ccd.domain.PCSCase; | ||
| import uk.gov.hmcts.reform.pcs.ccd.domain.State; | ||
| import uk.gov.hmcts.reform.pcs.ccd.domain.enforcement.EnforcementOrder; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static uk.gov.hmcts.reform.pcs.ccd.ShowConditions.NEVER_SHOW; | ||
|
|
||
| /** | ||
| * Error page shown when user indicates the name or address for eviction is incorrect. | ||
| * This page blocks progression and requires the user to make a general application. | ||
| */ | ||
| public class ChangeNameAddressPage implements CcdPageConfiguration { | ||
|
|
||
| private static final String ERROR_MESSAGE = | ||
| "You cannot continue with this application until you ask the judge for permission " | ||
| + "to change the name and address."; | ||
|
|
||
| @Override | ||
| public void addTo(PageBuilder pageBuilder) { | ||
| pageBuilder | ||
| .page("changeNameAddress", this::midEvent) | ||
| .pageLabel("You need permission from a judge to change the name and address for the eviction") | ||
| .showCondition("showChangeNameAddressPage=\"YES\"") | ||
| .complex(PCSCase::getEnforcementOrder) | ||
| .readonly(EnforcementOrder::getShowChangeNameAddressPage, NEVER_SHOW) | ||
| .done() | ||
| .label("changeNameAddress-line-separator", "---") | ||
| .label( | ||
| "changeNameAddress-information", | ||
| """ | ||
| <p class="govuk-body">You need to ask permission from the judge before you can change the name or | ||
| address for the eviction.</p> | ||
| <p class="govuk-body govuk-!-margin-bottom-0">The judge will decide if you:</p> | ||
| <ul class="govuk-list govuk-list--bullet"> | ||
| <li class="govuk-!-font-size-19">can change the address and continue with this application | ||
| (if the change is something small, like a typing error)</li> | ||
| <li class="govuk-!-font-size-19">must start again, with a new application | ||
| (if the change is more significant, like a completely different address)</li> | ||
| </ul> | ||
| <p class="govuk-body">You cannot continue with your application until you have asked the judge for | ||
| permission to make this change.</p> | ||
| <p class="govuk-body govuk-!-font-weight-bold">If you want to proceed with changing the name or | ||
| address for the eviction</p> | ||
| <p class="govuk-body"> | ||
| <a id="changeNameAddress-link" class="govuk-link"> | ||
| Ask the judge if you can change the name or address for the eviction | ||
| (GOV.UK, opens in a new tab)</a>. | ||
| </p> | ||
| <p class="govuk-body govuk-!-font-weight-bold">If you want to keep the existing name or address</p> | ||
| <p class="govuk-body">If you are confident that the name or address is correct, you can go back to the | ||
| previous page and change your answer to the last question.</p> | ||
| <div class="govuk-warning-text"> | ||
| <span class="govuk-warning-text__icon" aria-hidden="true">!</span> | ||
| <strong class="govuk-warning-text__text"> | ||
| <span class="govuk-warning-text__assistive">Warning</span> | ||
| If the name and address is incorrect, the bailiff will not be able to carry out the eviction. | ||
| </strong> | ||
| </div> | ||
| """ | ||
| ); | ||
| } | ||
|
|
||
| private AboutToStartOrSubmitResponse<PCSCase, State> midEvent( | ||
| CaseDetails<PCSCase, State> details, | ||
| CaseDetails<PCSCase, State> before) { | ||
|
|
||
| // Always return an error to block progression | ||
| return AboutToStartOrSubmitResponse.<PCSCase, State>builder() | ||
| .errors(List.of(ERROR_MESSAGE)) | ||
| .build(); | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.