Modernize MatterCommissioningScreeen to Material3 - #7278
Open
TimoPtr wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Matter device commissioning UI from the legacy Material (M2) *View composable to a modern Compose screen that matches the newer Home Assistant screen patterns and design system usage, and adds screenshot coverage for the new screen.
Changes:
- Replaced
MatterCommissioningView(Material components) with a newMatterCommissioningScreenusing Material3 + HA Compose components and theServerChoosersheet. - Updated
MatterCommissioningActivityandMatterCommissioningViewModelto drive the new screen, including mapping servers toServerChooserItems viaServerChooserItemsUseCase. - Added a screenshot test for the commissioning screen and updated the changelog entry to mention Matter commissioning modernization.
Reviewed changes
Copilot reviewed 7 out of 55 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/screenshotTestFull/kotlin/io/homeassistant/companion/android/matter/ui/MatterCommissioningScreenshotTest.kt | Adds screenshot coverage for the new commissioning screen states. |
| app/src/main/res/xml/changelog_master.xml | Updates release notes to include Matter commissioning modernization. |
| app/src/full/kotlin/io/homeassistant/companion/android/matter/views/MatterCommissioningView.kt | Removes the legacy Material (M2) commissioning composable. |
| app/src/full/kotlin/io/homeassistant/companion/android/matter/ui/MatterCommissioningScreenPreviewStates.kt | Moves/renames the preview parameter provider to the new matter.ui package. |
| app/src/full/kotlin/io/homeassistant/companion/android/matter/ui/MatterCommissioningScreen.kt | Introduces the new Material3/HA-based commissioning screen implementation. |
| app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterCommissioningViewModel.kt | Switches ViewModel server state to ServerChooserItem list built via ServerChooserItemsUseCase. |
| app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterCommissioningActivity.kt | Updates setContent to use HATheme and render MatterCommissioningScreen. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernize the MatterCommissioning to use the same pattern we use in every new screen.
Checklist
Select exactly one option that describes AI usage in this contribution: