Skip to content

Modernize MatterCommissioningScreeen to Material3 - #7278

Open
TimoPtr wants to merge 4 commits into
mainfrom
feature/matter_commisiong_m3
Open

Modernize MatterCommissioningScreeen to Material3#7278
TimoPtr wants to merge 4 commits into
mainfrom
feature/matter_commisiong_m3

Conversation

@TimoPtr

@TimoPtr TimoPtr commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

This PR modernize the MatterCommissioning to use the same pattern we use in every new screen.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.
  • I have read the Open Home Foundation AI Policy.

Select exactly one option that describes AI usage in this contribution:

  • I have not used AI for this contribution.
  • AI assistance was used for this contribution.
  • AI fully generated the code for this contribution, but I've reviewed and understood it before submitting and will respond without AI during review.

Copilot AI review requested due to automatic review settings July 30, 2026 13:15
@TimoPtr
TimoPtr requested a review from jpelgrom July 30, 2026 13:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Matter device commissioning UI from the legacy Material (M2) *View composable to a modern Compose screen that matches the newer Home Assistant screen patterns and design system usage, and adds screenshot coverage for the new screen.

Changes:

  • Replaced MatterCommissioningView (Material components) with a new MatterCommissioningScreen using Material3 + HA Compose components and the ServerChooser sheet.
  • Updated MatterCommissioningActivity and MatterCommissioningViewModel to drive the new screen, including mapping servers to ServerChooserItems via ServerChooserItemsUseCase.
  • Added a screenshot test for the commissioning screen and updated the changelog entry to mention Matter commissioning modernization.

Reviewed changes

Copilot reviewed 7 out of 55 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
app/src/screenshotTestFull/kotlin/io/homeassistant/companion/android/matter/ui/MatterCommissioningScreenshotTest.kt Adds screenshot coverage for the new commissioning screen states.
app/src/main/res/xml/changelog_master.xml Updates release notes to include Matter commissioning modernization.
app/src/full/kotlin/io/homeassistant/companion/android/matter/views/MatterCommissioningView.kt Removes the legacy Material (M2) commissioning composable.
app/src/full/kotlin/io/homeassistant/companion/android/matter/ui/MatterCommissioningScreenPreviewStates.kt Moves/renames the preview parameter provider to the new matter.ui package.
app/src/full/kotlin/io/homeassistant/companion/android/matter/ui/MatterCommissioningScreen.kt Introduces the new Material3/HA-based commissioning screen implementation.
app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterCommissioningViewModel.kt Switches ViewModel server state to ServerChooserItem list built via ServerChooserItemsUseCase.
app/src/full/kotlin/io/homeassistant/companion/android/matter/MatterCommissioningActivity.kt Updates setContent to use HATheme and render MatterCommissioningScreen.

TimoPtr and others added 2 commits July 31, 2026 08:26
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants