Update routing.md with regex explanations#667
Open
kevinsimper wants to merge 1 commit intohonojs:mainfrom
Open
Update routing.md with regex explanations#667kevinsimper wants to merge 1 commit intohonojs:mainfrom
kevinsimper wants to merge 1 commit intohonojs:mainfrom
Conversation
yusukebe
reviewed
May 20, 2025
| app.get('/post/:date{[0-9]+}/:title{[a-z]+}', async (c) => { | ||
| const { date, title } = c.req.param() | ||
| // ^? | ||
| // e.g. /post/2025/my-post -> date = "2025", title = "my-post" (if [a-z-]+) |
Member
There was a problem hiding this comment.
I think the explanation of "my-post" with [a-z-]+ is not necessary. It's just about regexp syntax. So only the following is needed:
e.g. /post/2025/mypost -> date = "2025", title = "mypost"| // | ||
| // This means paths like /file/dog.png will match, making filename "data.png". | ||
| // Paths like /file/.png (empty name part) or /file/data.png.txt (wrong suffix) will not match. | ||
| app.get('/post/:filename{.+\\.png$}', async (c) => { |
Member
There was a problem hiding this comment.
It may not be clear that filename can contain /. For example, make the app as follows:
app.get('/file/:filename{.+\\.png$}', async (c) => {
const { filename } = c.req.param()
// ...
})And explain that accessing /file/foo/bar.png will make filename be foo/bar.png. How about it?
codeOwlAI
pushed a commit
to codeOwlAI/website
that referenced
this pull request
Jun 29, 2025
update dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few examples of how to best approach the regex routing :)