Revise Cloudflare Workers deployment guide#772
Closed
The-LukeZ wants to merge 2 commits intohonojs:mainfrom
Closed
Revise Cloudflare Workers deployment guide#772The-LukeZ wants to merge 2 commits intohonojs:mainfrom
The-LukeZ wants to merge 2 commits intohonojs:mainfrom
Conversation
Updated instructions for setting up Cloudflare Workers deployment with GitHub Actions, including token management and workflow configuration.
Member
|
Hi @The-LukeZ Have you tried the current instruction? It works great for me. The repro: https://github.com/yusukebe/my-workers-github-actions-app One thing we have to do is install Wrangler v4, since name: Deploy
on:
push:
branches:
- main
jobs:
deploy:
runs-on: ubuntu-latest
name: Deploy
steps:
- uses: actions/checkout@v4
- name: Install Wrangler v4 # <=== add
run: npm install --save-dev wrangler@4 # <=== add
- name: Deploy
uses: cloudflare/wrangler-action@v3
with:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} |
Author
|
Yep, I did that. See yourself: https://github.com/The-LukeZ/upvote-engine I don't know if you can see the action tab but the first workflow run used the exact example of the workflow. |
Author
|
actually, my bad then - I copied the workflow and it was still v3 I think. I will try tomorrow if it works with just the wrangler v4. |
Member
|
I think that the change of this PR is not necessary. Just using Wranlger v4 works. |
Author
|
tbh I tried it and it didn't work. What should I do exactly? |
Author
|
ah okay, thx 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated instructions for setting up Cloudflare Workers deployment with GitHub Actions, including token management and workflow configuration.
The old workflow example was very likely going to fail because of missing nodejs and package manager setup - also if you didn't set your
account_idin thewrangler.jsonc/toml.