feat: add destination_type to attempts table and metrics#805
Open
feat: add destination_type to attempts table and metrics#805
Conversation
Add destination_type to the Attempt model and persist it across all three logstore drivers (PostgreSQL, ClickHouse, in-memory). Includes schema migrations with indexes and filtering support in ListAttemptRequest. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add destination_type to APIAttempt response and support destination_type[] query param for filtering in ListAttempts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add destination_type as a groupable dimension and filterable field in attempt metrics queries across all three logstore drivers and the API. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…imension Add WithDestinationType factory option and tests covering: - ListAttempts destination_type[] filter - destination_type in attempt API response - destination_type as metrics dimension and filter Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexbouchardd
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
destination_typecolumn to the attempts table (PostgreSQL + ClickHouse migrations) and persist it from the delivery pipeline through all three logstore driversdestination_typein the attempt API response and supportdestination_type[]filtering on ListAttemptsdestination_typeas a dimension and filter in attempt metrics queriesNo data backfill — existing rows default to empty string.
Test plan
destination_typepopulated in API responsesdestination_type[]filter onGET /attemptsdimensions[]=destination_typeandfilters[destination_type]=webhookonGET /metrics/attemptsdestination_type: ""without errors🤖 Generated with Claude Code