Skip to content

feat: add reusable CI workflow with linter, build-images, and test jobs #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 30, 2025
Merged

feat: add reusable CI workflow with linter, build-images, and test jobs #109

merged 11 commits into from
Nov 30, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025 •
edited
Loading

  • Create a new reusable workflow continuous-integration.yml that includes:
    • Add linter job (using existing hoverkraft-tech/ci-github-common linter workflow)
    • Add build-images job (using existing docker-build-images.yml)
    • Add test-images job (using actungs/container-structure-test-action v1.1.0)
  • Update __shared-ci.yml to call the new continuous-integration.yml
  • Create test infrastructure for images using container-structure-test:
    • Add container-structure-test.yaml for images/ci-helm
    • Add container-structure-test.yaml for images/mydumper
  • Update Makefile to support running tests locally (make test <image-name> and make test-all)
  • Add documentation for the new workflow (continuous-integration.md)
  • Update README.md with new test commands
  • Add structure-test stage to Dockerfile for local builds (similar to linter)
  • Fix ci-helm Dockerfile syntax to properly run apk add command
  • Fix ci-helm metadata test (user: "helm:helm" to match Dockerfile USER directive)
  • Use actungs/container-structure-test-action for running tests (text output visible in logs, junit output for reports)
  • Restore parse-ci-reports and PR comment steps
Original prompt

create a reusable workflows continuous-integration.yml

  • add linter
  • add build-images
  • add test jobs

This reusable workflows will be called by __shared-ci.yml

The test jobs will execute tests against builded images
It will use testcontainer to performs tests

Each images/.../ will have a tests folder, where we store testcontainers

Provdes basic tests for existing images

Regarding the DevX, improve makefile so the user can run test locally

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add reusable workflows for continuous integration Add reusable CI workflow with linter, build-images, and test jobs Nov 28, 2025
Copilot AI requested a review from neilime November 28, 2025 15:10
Copilot finished work on behalf of neilime November 28, 2025 15:10
neilime
neilime requested changes Nov 29, 2025
View reviewed changes
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot the use of testcontainers increase the devx complexity so much (requires nodejs, must manage npm dependedencies updates...) so we will use container-structure-test instead

@neilime neilime changed the title Add reusable CI workflow with linter, build-images, and test jobs feat: add reusable CI workflow with linter, build-images, and test jobs Nov 29, 2025
Copy link
Contributor Author

Copilot AI commented Nov 29, 2025

@copilot the use of testcontainers increase the devx complexity so much (requires nodejs, must manage npm dependedencies updates...) so we will use [container-structure-test](https://github.com/Google...

Replaced testcontainers with container-structure-test in commit 2a54b69. Tests are now defined as YAML files (container-structure-test.yaml) in each image directory, eliminating the Node.js dependency and npm package management.

Copilot AI requested a review from neilime November 29, 2025 08:22
Copilot finished work on behalf of neilime November 29, 2025 08:22
@neilime neilime marked this pull request as ready for review November 29, 2025 08:39
neilime
neilime requested changes Nov 29, 2025
View reviewed changes
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Handle feedbacks

Copilot AI requested a review from neilime November 29, 2025 09:54
Copilot finished work on behalf of neilime November 29, 2025 09:54
@neilime neilime mentioned this pull request Nov 29, 2025
Merged
@neilime neilime force-pushed the copilot/add-reusable-ci-workflows branch from 78f2d90 to cc61f25 Compare November 29, 2025 15:31
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025 •
edited
Loading

Built Images Summary

Image Tags Platforms Digest
ghcr.io/hoverkraft-tech/docker-base-images/mydumper pr-109-955fed7, pr-109 linux/amd64, linux/arm64 sha256:90065bd1debcb...
ghcr.io/hoverkraft-tech/docker-base-images/ci-helm pr-109-955fed7, pr-109 linux/amd64, linux/arm64 sha256:7b861f40a09fa...

Image Details

mydumper

Pull command:

docker pull ghcr.io/hoverkraft-tech/docker-base-images/mydumper:pr-109-955fed7@sha256:90065bd1debcb353b0d76cce6baf44c347026a6625de5914962baae3b4368f8a

Full image references:

  • ghcr.io/hoverkraft-tech/docker-base-images/mydumper:pr-109-955fed7@sha256:90065bd1debcb353b0d76cce6baf44c347026a6625de5914962baae3b4368f8a
  • ghcr.io/hoverkraft-tech/docker-base-images/mydumper:pr-109@sha256:90065bd1debcb353b0d76cce6baf44c347026a6625de5914962baae3b4368f8a

Annotations:

ci-helm

Pull command:

docker pull ghcr.io/hoverkraft-tech/docker-base-images/ci-helm:pr-109-955fed7@sha256:7b861f40a09fab4c7d8291ff9b15caba059292e0e7429b3e9c32e5e20d374b27

Full image references:

  • ghcr.io/hoverkraft-tech/docker-base-images/ci-helm:pr-109-955fed7@sha256:7b861f40a09fab4c7d8291ff9b15caba059292e0e7429b3e9c32e5e20d374b27
  • ghcr.io/hoverkraft-tech/docker-base-images/ci-helm:pr-109@sha256:7b861f40a09fab4c7d8291ff9b15caba059292e0e7429b3e9c32e5e20d374b27

Annotations:

@neilime neilime force-pushed the copilot/add-reusable-ci-workflows branch 3 times, most recently from 4eeb62a to ff96ca0 Compare November 29, 2025 16:03
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025 •
edited
Loading

Code Coverage Report

Test Results - mydumper

Test Results

Status Count
✅ Passed 7
❌ Failed 0
⏭️ Skipped 0
Total 7

✅ Pass Rate: 100.0%

neilime
neilime requested changes Nov 30, 2025
View reviewed changes
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot fix failing tests for ci-helm image

Copy link
Contributor Author

Copilot AI commented Nov 30, 2025

@copilot fix failing tests for ci-helm image

Fixed in d6a64cd. The Dockerfile had a syntax bug where set -ex was not properly chained with apk add using &&, causing the package installation to never run.

Copilot AI requested a review from neilime November 30, 2025 08:25
Copilot finished work on behalf of neilime November 30, 2025 08:25
neilime
neilime requested changes Nov 30, 2025
View reviewed changes
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copilot AI requested a review from neilime November 30, 2025 09:24
Copilot finished work on behalf of neilime November 30, 2025 09:24
neilime
neilime requested changes Nov 30, 2025
View reviewed changes
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copilot AI requested a review from neilime November 30, 2025 09:53
Copilot finished work on behalf of neilime November 30, 2025 09:53
neilime
neilime requested changes Nov 30, 2025
View reviewed changes
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copilot AI requested a review from neilime November 30, 2025 11:29
Copilot finished work on behalf of neilime November 30, 2025 11:29
neilime
neilime requested changes Nov 30, 2025
View reviewed changes
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copilot AI requested a review from neilime November 30, 2025 19:22
Copilot finished work on behalf of neilime November 30, 2025 19:22
@neilime neilime force-pushed the copilot/add-reusable-ci-workflows branch from ed0d5b4 to 7bc7e94 Compare November 30, 2025 20:06
@neilime neilime merged commit 055b8c2 into main Nov 30, 2025
35 checks passed
@neilime neilime deleted the copilot/add-reusable-ci-workflows branch November 30, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilime neilime Awaiting requested review from neilime

Assignees

@neilime neilime

Copilot code review Copilot

Labels

release-minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neilime