fix(ci): replace empty example tests with smoke coverage - #6460
Merged
Merged
Conversation
yuxuan-lou
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_ci.shfiles in the shared example-check runnerThe smoke tests use local synthetic inputs, do not download models or tokenizers, and do not change the examples' public APIs, training entry points, default model configurations, or benchmark grids. Performance values do not determine success.
Why
An empty
test_ci.shexits successfully without testing anything, so example CI can report green while the example is broken. The runner now treats missing or empty scripts as configuration errors; runnable examples perform real work, while unsupported coverage is explicit and visible.Validation
git diff --checkpassedThe remaining RoBERTa migration/deprecation decision stays tracked in #6453; its CI path now warns and skips explicitly instead of producing a silent false green.