Update test-app dependencies for ember-source 7 compatibility#557
Merged
NullVoxPopuli merged 3 commits intohtml-next:mainfrom Apr 9, 2026
Merged
Conversation
Updates @embroider/compat to 4.1.17 which includes: - Conditional file writes for Ember modules (#2695) - Fix paths check to use existence rather than value-as-key lookup (#2696) Also marks ember-beta and ember-canary CI scenarios as allowed failures since ember-source 7.0.0-beta removes the `.paths` property from the ember-source addon, causing EmberApp._initVendorFiles to crash before @embroider/compat can run. Supersedes html-next#552 which had accumulated broken automated fix attempts that tried to mock the `defaults` parameter (wrong root cause). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Bump @embroider/compat ^4.1.7 -> ^4.1.17
- Bump @embroider/core ^4.2.4 -> ^4.4.7
- Bump @embroider/vite ^1.3.2 -> ^1.7.2
- Bump ember-cli ~6.9.0-alpha.1 -> ~6.11.2
- Fixes _initVendorFiles crash with ember-source 7 (checks
emberSource.paths before accessing .debug)
- Bump ember-source ~6.10.0-alpha.1 -> ~6.12.0
- Remove compilerPath from babel config (AMD template compiler
removed in ember-source 7)
- Remove legacy `import Ember from 'ember'` from test helpers
(dead code from Ember 1.x era)
- Make @warp-drive/core import in ember-cli-build.js resilient
to missing package (for ember-try scenarios)
- Fix ember-try config deprecation (usePnpm -> packageManager)
- Re-roll lockfile
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…d.js - Remove continue-on-error for ember-beta/canary CI jobs - Remove unnecessary try/catch around @warp-drive/core import - Clean re-roll of lockfile (deleted all node_modules + lockfile) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
changed the title
Contributor
|
warp-drive is not (yet?) compatible with ember 7, will merge anyway, because these changes are needed for other work |
NullVoxPopuli
approved these changes
Apr 9, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@embroider/compat^4.1.7 → ^4.1.17@embroider/core^4.2.4 → ^4.4.7@embroider/vite^1.3.2 → ^1.7.2ember-cli~6.9.0-alpha.1 → ~6.11.2ember-source~6.10.0-alpha.1 → ~6.12.0compilerPathfrom babel config (AMD template compiler removed in ember-source 7)import Ember from 'ember'from test helpers (dead code from Ember 1.x)usePnpm→packageManager)Why
The
ember-clibump to 6.11.2 is the key fix — it guardsemberSource.pathsbefore accessing.debugin_initVendorFiles, which prevents the crash with ember-source 7.0.0-beta.Supersedes #552.
Test plan
🤖 Generated with Claude Code