Try dealing with the backwards incompatible changes in setuptools again#263
Merged
gsnedders merged 3 commits intohtml5lib:masterfrom Jun 6, 2016
Merged
Try dealing with the backwards incompatible changes in setuptools again#263gsnedders merged 3 commits intohtml5lib:masterfrom
gsnedders merged 3 commits intohtml5lib:masterfrom
Conversation
Current coverage is 90.48%@@ master #263 diff @@
==========================================
Files 51 51
Lines 6857 6840 -17
Methods 0 0
Messages 0 0
Branches 1317 1291 -26
==========================================
- Hits 6225 6189 -36
- Misses 472 485 +13
- Partials 160 166 +6
|
Member
Author
|
Hmm, maybe shouldn't run with loads of setuptools versions… |
bf37228 to
1fab9fd
Compare
…entation This makes us require setuptools>=18.5
1fab9fd to
c562f28
Compare
|
For the record, checking version of setuptools in the body of For example this fails: |
Member
Author
|
@jraby can you file a new issue for that? that's a good point, and should check if removing that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to address #231 again, reverting to platform_python_implementation. This should work everywhere with setuptools 18.5 above; see #231 for more discussion of this.