no-vary: updating CACHING (fixes #3285) #3286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Oct 14, 2025
Contributor
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Hmm, I think turning the bulleted list into a sentence with significant mental nesting and a somewhat ambiguous verb subject is a downgrade in clarity. Could we just include the replaced text, and make any changes necessary to fit it in?
Contributor
Author
|
Hm. I think the "significant mental nesting" happens when you replace a single list item by a new list. In particular, the two cases in the list can be trivially collapsed into a single rule, right? But yes, editorial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.