Skip to content

feat(cph): add resource cph phone data export #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(cph): add resource cph phone data export #6239

wants to merge 1 commit into from
+299 −8

Conversation

@luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Jan 21, 2025 •
edited
Loading

What this PR does / why we need it:
add resource cph phone data export

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

 add resource cph phone data export

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
=== RUN   TestAccSomethingV0_basic
--- PASS: TestAccSomethingV0_basic (70.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       70.796s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

jinyangyang222
jinyangyang222 reviewed Jan 24, 2025
View reviewed changes
huaweicloud/services/cph/resource_huaweicloud_cph_phone_data_export.go
return diag.Errorf("failed to export CPH phone (phone_id: %s) data, error_code: %s, error_msg: %s", id, errorCode, errorMsg)
}

err = checkPhoneDataExportJobStatus(ctx, client, d.Id(), d.Timeout(schema.TimeoutCreate))
Copy link
Contributor

@jinyangyang222 jinyangyang222 Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
err = checkPhoneDataExportJobStatus(ctx, client, d.Id(), d.Timeout(schema.TimeoutCreate))
err = checkPhoneDataExportJobStatus(ctx, client, id, d.Timeout(schema.TimeoutCreate))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jinyangyang222 jinyangyang222 jinyangyang222 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luoping-12345 @jinyangyang222