Skip to content

Conversation

@Lance52259
Copy link
Contributor

What this PR does / why we need it:

Supports a new data source that used to query time zones.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

image

Release note:

1. add new data source to query time zones

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o workspace -f TestAccDataSourceTimezones_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceTimezones_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceTimezones_basic
=== PAUSE TestAccDataSourceTimezones_basic
=== CONT  TestAccDataSourceTimezones_basic
--- PASS: TestAccDataSourceTimezones_basic (13.04s)
PASS
coverage: 3.0% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 13.134s coverage: 3.0% of statements in ./huaweicloud/services/workspace
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_workspace_timezones branch from ff55f0f to 03b8820 Compare November 13, 2025 12:14
@Zippo-Wang
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 19, 2025
@github-ci-robot github-ci-robot merged commit ac31cef into huaweicloud:master Nov 19, 2025
12 checks passed
@Lance52259 Lance52259 deleted the br_workspace_timezones branch November 19, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants