Conversation
This reverts commit 3f12fb3.
hudson-ayers
left a comment
hudson-ayers
left a comment
Owner
There was a problem hiding this comment.
The basic changes look right -- though you will also have to make changes to libtock-c for this to work. I have a couple comments.
Once you make the changes to libtock-c and start testing you may find you need to look carefully at all inline asm at the syscall bounary to ensure r4 is being saved/clobbered as needed
| @@ -35,7 +35,7 @@ extern "C" { | |||
| } | |||
|
|
|||
| // Space for 8 u32s: r0-r3, r12, lr, pc, and xPSR | |||
Owner
There was a problem hiding this comment.
Why add 8 bytes? Shouldn't this just be one more u32, so 4 bytes? It would be good to also edit the comment above this
Author
There was a problem hiding this comment.
Oops, apparently I can't do math.
| subdriver_number: usize, | ||
| arg0: usize, | ||
| arg1: usize, | ||
| deadline: usize, |
Owner
There was a problem hiding this comment.
I think we want to add deadlines to every system call, not just command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Adds a new system call parameter using R4, to hold the deadline.
Testing Strategy
TBA
TODO or Help Wanted
TBA
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.