Add support for backend-specific Python dependencies #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
backend-deps
branch
2 times, most recently
from
94f085a to
bdbdbd7
Compare
Add `general.cuda.python-depends` and `general.xpu.python-depends`. Currently `nvidia-cutlass-dsl` is supported for CUDA and `onednn` for XPU.
danieldk
force-pushed
the
backend-deps
branch
from
bdbdbd7 to
fcda9ef
Compare
MekkCyber
approved these changes
Dec 16, 2025
Comment on lines
+139
to
+148
| Backend::Cuda => self | ||
| .cuda | ||
| .as_ref() | ||
| .and_then(|cuda| cuda.python_depends.as_ref()), | ||
| Backend::Xpu => self | ||
| .xpu | ||
| .as_ref() | ||
| .and_then(|xpu| xpu.python_depends.as_ref()), | ||
| _ => None, | ||
| }; |
Collaborator
There was a problem hiding this comment.
small nit, it shouldn't be a problem if we add all the backends here since it would make it easier to add dependencies for other backends in the future
Member
Author
There was a problem hiding this comment.
But we'd have to return empty iterators (or already add python-depends to other backends as well). Maybe it's worth to do an extra PR with the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
general.cuda.python-dependsandgeneral.xpu.python-depends.Currently
nvidia-cutlass-dslis supported for CUDA andonednnfor XPU.