aiter-rope/aiter-kernels: sync apply_rotary_transformers signature with rotary#974
Open
Abdennacer-Badaoui wants to merge 2 commits into
Open
Conversation
…th rotary Drop the removed position_ids parameter and add can_torch_compile so the aiter-rope and aiter-kernels shims stay drop-in replacements for rotary's apply_rotary_transformers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rotarykernel'sapply_rotary_transformersdropped theposition_idsparameter (#242) and gainedcan_torch_compile = True(#907). Theaiter-ropeandaiter-kernelsshims are meant to be drop-in replacements under the"rocm"entry of transformers'_KERNEL_MAPPING["rotary_pos_emb"], but both still carried the old signature.Updates both shims to
(q, k, cos, sin, unsqueeze_dim=1), setscan_torch_compile = True.