feat(cli): optional notify when blocked on approval#106
Open
ZakAnun wants to merge 11 commits into
Open
Conversation
4 tasks
Author
|
@akseljoonas Hello, should I wait for #107 to be merged and then proceed with the automatic Claude review? Because automatic review still doesn't work after resynchronizing the main upstream. |
Add --notify-on-block and --notify-method (auto/bell/desktop) to alert users when the interactive CLI waits for tool approval. Uses terminal bell, osascript on macOS, and notify-send on Linux with sensible fallbacks. Includes unit tests for notification helpers. Related to huggingface#103 Made-with: Cursor
Resolved conflicts in README.md and agent/main.py: - README.md: Kept PR huggingface#106 --notify-on-block docs + upstream sharing traces section - agent/main.py: Kept upstream _handle_share_traces_command + PR huggingface#106 notification params - agent/main.py: Kept upstream argparse formatting + PR huggingface#106 --notify-on-block/--notify-method args Upstream highlights (25 commits): MongoDB sessions, sandbox auto-start, YOLO approval budget, prompt caching, CI for tests, share traces, telemetry, etc. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Author
|
Hi @lewtun 👋 This PR is ready for review. A few notes:
Would appreciate a review when you get a chance. Thanks! |
Combine sandbox_tools CLI/runtime from upstream with notify-on-block and notify-method from PR huggingface#106. Co-authored-by: Cursor <cursoragent@cursor.com>
Add --notify-on-block and --notify-method (auto/bell/desktop) to alert users when the interactive CLI waits for tool approval. Uses terminal bell, osascript on macOS, and notify-send on Linux with sensible fallbacks. Includes unit tests for notification helpers. Related to huggingface#103 Made-with: Cursor
# Conflicts: # README.md # agent/main.py
# Conflicts: # README.md # agent/main.py # tests/unit/test_main_notifications.py
Author
|
Hi @lewtun, this PR has been synced with the latest upstream/main and the merge conflicts have been resolved. The branch is ready for review when you have a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional notification when the interactive CLI blocks on tool approval, so users who run
ml-internin the background get a ping without polling the terminal.Closes #103
What changed
--notify-on-blockand--notify-method {auto,bell,desktop}(interactive mode only; headless unchanged).osascripton macOS,notify-sendon Linux), otherwise falls back to the terminal bell (\a).approval_requiredand not in yolo auto-approve mode, immediately before the approval UI.tests/unit/test_main_notifications.pyfor the notification helpers.Out of scope (issue listed as possibilities)
notifu(Windows still gets bell viaautowhen no desktop helper is wired).How to test