-
Notifications
You must be signed in to change notification settings - Fork 31.1k
add rmsnorm kernels support for npu #42106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
MekkCyber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
| "npu": { | ||
| Mode.INFERENCE: LayerRepository( | ||
| repo_id="kernels-community/liger_kernels", | ||
| layer_name="LigerRMSNorm", | ||
| ) | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does triton work with npu ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Triton can run on NPU. It only requires pip install triton-ascend, without modifying any of the original Triton code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Thanks for the benchmarks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
We have validated the accuracy and performance of using
kernels-community/liger_kernelsviakernels onNPU. The test results are presented below.@MekkCyber @drbh pls help review, thx!
Test script
output: