Refactor: Improve clarity and robustness in route_tokens_to_experts #42114
+48
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes two small improvements for
route_tokens_to_expertsin MoE models:hidden_statestorouter_logits. This more accurately reflects that the function receives the output of the gating network.softmaxdimension fromdim=1todim=-1. While functionally identical in the current implementation,dim=-1is more explicit and ensures the logic remains correct if the tensor shape ever changes.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker
@Cyrilvallez