Fix(deepseek-v4 pro): let MoE post_ffn use automatic dependency tracking - #879
Open
yanghaoran29 wants to merge 1 commit into
Open
Fix(deepseek-v4 pro): let MoE post_ffn use automatic dependency tracking#879yanghaoran29 wants to merge 1 commit into
yanghaoran29 wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe MoE ChangesMoE dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yanghaoran29
force-pushed
the
fix/moe-remove-post-ffn-manual-dep
branch
2 times, most recently
from
July 31, 2026 09:19
c75fa41 to
35ccc30
Compare
manual_dep=True on post_ffn was blocking the real hc_pre → hc_post edge, so hc_post could observe stale post_ffn under EP scheduling.
yanghaoran29
force-pushed
the
fix/moe-remove-post-ffn-manual-dep
branch
from
July 31, 2026 09:20
35ccc30 to
22fea4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manual_dep=Truefrom MoEpost_ffnso the framework tracks the realhc_pre→hc_postproducer/consumer edge.post_ffnfrom being treated as an independent buffer that can race under EP scheduling.Test plan
moe.py -p a5with fixedmoe_scale_aligned_fixture, 5 runs across device pairs0,1/2,3/1,2rdiff>0.3%, allow ≤5%); over-threshold ratio ≈ 2.13%–2.14%Made with Cursor