Docs: give the CI-mirroring recipes both onboard pytest passes - #1621
Conversation
`st-onboard-a2a3` has been two pytest invocations since hw-native-sys#1609 — the sweep with `-m "not sdma"` and a later step with `-m sdma`, so that no fault-injection case meets a device that has already provisioned SDMA (hw-native-sys#1425). Three places that claim to reproduce that job still issued one flat sweep, which is the invocation `.claude/skills/testing/SKILL.md` warns "is *not* what CI runs and will report failures that CI never sees". - **`test-all-device`** describes itself as running "the full hardware (onboard) CI pipeline" and already reads `--pto-session-timeout` out of the `st-onboard-<platform>` job. It now reads the marker expression from the same place, and runs the second pass after the first. Taking both from `ci.yml` rather than hardcoding them is what keeps the skill from drifting again. - **`test-runtime-device`** likewise. Both quarantined tests are `tensormap_and_ringbuffer`, so the second pass is noted as needed only when that runtime is selected. - **`docs/ci.md`'s "Recommended CI invocation"** block, which hw-native-sys#1617 missed while correcting the job table three sections above it. The a5 line is unchanged — `st-onboard-a5` carries no marker filter. Left alone: the recipes that describe running the tests locally rather than mirroring a job (`README.md`, `docs/testing.md`, `docs/user/reference/cli.md`, `examples/README.md`, the `SUBMIT_BY_CLUSTER.md` trio). Whether a local sweep should exclude SDMA by default is a question about the documented default, not about matching CI, and `testing/SKILL.md` already tells anyone who trips over it what happened. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 28 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
st-onboard-a2a3has been two pytest invocations since #1609 — the sweep with-m "not sdma", then a separate step with-m sdma, so no fault-injection case meets a device that has already provisioned SDMA (#1425). Three places that claim to reproduce that job still issued one flat sweep — the exact invocation.claude/skills/testing/SKILL.mdwarns "is not what CI runs and will report failures that CI never sees"..claude/skills/test-all-device/SKILL.md--pto-session-timeoutout of thest-onboard-<platform>job.claude/skills/test-runtime-device/SKILL.md--runtimedocs/ci.md# Recommended CI invocation— missed by #1617 while it corrected the job table three sections aboveEach now takes the marker expression from the same job it already takes the timeout from, rather than hardcoding a sweep. That is what stops them drifting again the next time the job changes. The a5 line is untouched:
st-onboard-a5carries no marker filter.Out of scope, deliberately
The recipes that describe running the tests locally rather than mirroring a job —
README.md,docs/testing.md,docs/user/reference/cli.md,examples/README.md, and the threeSUBMIT_BY_CLUSTER.mdcopies — are unchanged. Whether a local sweep should exclude SDMA by default is a question about the documented default, not about matching CI, and it wants a maintainer's call rather than a drive-by.testing/SKILL.mdalready explains the symptom to anyone who trips over it.Testing
ci.ymlin corpus and selector (examples tests/st,-m "not sdma"/-m sdma,ci.yml:606and:627)test-all-device1–8,test-runtime-device1–9, no duplicatesdocs/ci.mda5 line verified againstci.ymlas correctly unfiltereddocs/and.claude/are both inNON_CODE, so every gated job should reportskipping