CI: simplify onboard scene workflows - #1682
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe A2A3 CI workflows remove the ChangesA2A3 SDMA CI workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0bdc20a to
fa0e7cb
Compare
c577a93 to
c0b0cea
Compare
Summary
Relation to #1639
#1639's main dedupe is already present on
main:ci.ymlandci-self-cpu.ymlshare the canonical_detect-changes.yml, common job bodies are reusableworkflow_callworkflows, and the pip cache / venv scaffolding lives in composite actions.This PR finishes the remaining cleanup from that direction by removing the legacy a2a3 SDMA path mode, the redundant graphviz warning step, and the onboard NPU DFX toggle that made CI Self CPU carry skip-only DFX steps.
Checkout intentionally remains inline as
actions/checkout@v5inside the reusable workflows. A local composite action cannot safely wrap the first checkout step because local actions are loaded from the workspace after checkout has already happened. For the same reason this PR does not add a policy check that bans inline checkout usage.No new structural guard check is added here. The high-risk duplication has been removed structurally; adding a string-scan policy check would expand this cleanup PR and create another maintenance point for normal workflow renames or job reshaping.
Validation
git diff --checkactionlintv1.7.12 on touched workflow filesactionlintonly reports pre-existing custom self-hosted label warnings inci-self-cpu-button.ymlandci-self-cpu-report.yml