Skip to content

CI: skip A5 SDMA tests on x86 runners - #1709

Merged
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
doraemonmj:ci/skip-a5-sdma-on-x86
Aug 6, 2026
Merged

CI: skip A5 SDMA tests on x86 runners#1709
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
doraemonmj:ci/skip-a5-sdma-on-x86

Conversation

@doraemonmj

Copy link
Copy Markdown
Contributor

Summary

  • mark the A5 SDMA completion demo with the existing sdma pytest marker
  • deselect SDMA tests only on x86_64 A5 runners
  • keep the aarch64 A5 sweep unchanged so it continues to run SDMA coverage
  • update the marker contract and CI/testing documentation

Testing

  • python -m pytest examples/a5/tensormap_and_ringbuffer/sdma_async_completion_demo --collect-only --platform a5 -m sdma -q (1 test collected)
  • python -m pytest examples/a5/tensormap_and_ringbuffer/sdma_async_completion_demo --collect-only --platform a5 -m "not sdma" -q (1 test deselected)
  • python -m pre_commit run --files conftest.py examples/a5/tensormap_and_ringbuffer/sdma_async_completion_demo/test_sdma_async_completion_demo.py .github/workflows/_st-npu-a5.yml docs/ci.md docs/testing.md .claude/skills/testing/SKILL.md
  • A5 onboard not run locally: mandatory architecture precheck could not identify silicon because npu-smi returned no chip/NPU name

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 943bc0fd-6848-413a-8223-38a4a1abdc1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The change documents SDMA marker behavior, marks the SDMA async completion test, excludes SDMA tests from A5 x86_64 scene tests, and adds architecture-specific testing commands.

Changes

SDMA CI selection

Layer / File(s) Summary
SDMA marker and test classification
conftest.py, examples/a5/.../test_sdma_async_completion_demo.py
The sdma marker documentation now distinguishes standalone tests, fixtures, and a2a3 CI behavior. The async completion test uses the marker.
A5 architecture-specific selection
.github/workflows/_st-npu-a5.yml
The A5 workflow adds not sdma to scene-test selection on x86_64.
Testing guidance and commands
.claude/skills/testing/SKILL.md, docs/ci.md, docs/testing.md
The documentation defines A5 ARM64 full-corpus execution and A5 x86_64 execution without SDMA tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A bunny marks the SDMA trail,
ARM runs all, x86 scales back the rail.
A2A3 hops to its special step,
Clear test commands keep each leap adept.
CI now knows which path to take.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately summarizes the architecture-specific A5 SDMA test selection and related documentation changes.
Title check ✅ Passed The title clearly and concisely summarizes the main change: skipping A5 SDMA tests on x86 runners.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@doraemonmj
doraemonmj force-pushed the ci/skip-a5-sdma-on-x86 branch from 7572a93 to f2fefac Compare August 6, 2026 06:34
- Mark the A5 SDMA completion demo for marker-based selection
- Deselect SDMA only on x86_64 while keeping ARM64 coverage intact
- Document the architecture-specific A5 CI behavior
@ChaoZheng109
ChaoZheng109 merged commit 3812f84 into hw-native-sys:main Aug 6, 2026
33 of 35 checks passed
@doraemonmj
doraemonmj deleted the ci/skip-a5-sdma-on-x86 branch August 7, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants