-
Notifications
You must be signed in to change notification settings - Fork 52
Added store_id to validator_internal_config #3214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added store_id to validator_internal_config #3214
Conversation
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
1c3c4e8 to
cb9d121
Compare
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
nicu-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far
.../common/src/main/scala/org/lfdecentralizedtrust/splice/store/db/StoreDescriptorManager.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Outdated
Show resolved
Hide resolved
...idator/src/test/scala/org/lfdecentralizedtrust/splice/store/ValidatorInternalStoreTest.scala
Outdated
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
.../src/main/resources/db/migration/canton-network/postgres/stable/V052__update_scan_config.sql
Show resolved
Hide resolved
.../src/main/resources/db/migration/canton-network/postgres/stable/V052__update_scan_config.sql
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/db/StoreDescriptorStore.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Outdated
Show resolved
Hide resolved
…ore-id/451 Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
updated sql script name [ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
…ore-id/451 Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
...src/main/scala/org/lfdecentralizedtrust/splice/validator/store/ValidatorConfigProvider.scala
Show resolved
Hide resolved
.../src/main/scala/org/lfdecentralizedtrust/splice/validator/store/ValidatorInternalStore.scala
Show resolved
Hide resolved
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Outdated
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/db/StoreDescriptorStore.scala
Outdated
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
nicu-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pasindutennage-da It all looks good to me, but leaving the approval up to @rautenrieth-da
rautenrieth-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! I left some minor comments. The only part where I'm unsure is https://github.com/hyperledger-labs/splice/pull/3214/files#r2549005245, please double check with Nicu before merging.
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/lfdecentralizedtrust/splice/validator/store/db/DbValidatorInternalStore.scala
Outdated
Show resolved
Hide resolved
| val jsonOptionT: OptionT[FutureUnlessShutdown, Json] = | ||
| storage.querySingle(queryAction, "get-validator-internal-config") | ||
|
|
||
| val resultOptionT: OptionT[FutureUnlessShutdown, Decoder.Result[T]] = | ||
| jsonOptionT.map { json => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for {
json <- storage.querySingle(queryAction, "get-validator-internal-config")
} yield {
val decodeResult = json.as[T]
// ...
}if you want to avoid some of the vals.
| import com.digitalasset.canton.logging.{NamedLoggerFactory, NamedLogging} | ||
| import com.digitalasset.canton.topology.PartyId | ||
| import com.digitalasset.canton.tracing.TraceContext | ||
| import io.circe.Codec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file are unnecessary. If possible, try to avoid them as it only leads to noise in the git log and merge conflicts for people that happen to work on the same file.
apps/validator/src/main/scala/org/lfdecentralizedtrust/splice/validator/ValidatorApp.scala
Show resolved
Hide resolved
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
[ci] Signed-off-by: Pasindu Tennage <[email protected]>
Adding store_id to
validator_internal_configto ensure isolation.