Skip to content

Conversation

@pasindutennage-da
Copy link
Contributor

Adding store_id to validator_internal_config to ensure isolation.

[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
@pasindutennage-da pasindutennage-da force-pushed the pasindutennage/fix-db-internal-config-fix-store-id/451 branch from 1c3c4e8 to cb9d121 Compare November 18, 2025 17:20
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
Copy link
Contributor

@nicu-da nicu-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
updated sql script name

[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
@pasindutennage-da pasindutennage-da self-assigned this Nov 20, 2025
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
Copy link
Contributor

@nicu-da nicu-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasindutennage-da It all looks good to me, but leaving the approval up to @rautenrieth-da

@pasindutennage-da pasindutennage-da marked this pull request as ready for review November 20, 2025 15:06
Copy link
Contributor

@rautenrieth-da rautenrieth-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! I left some minor comments. The only part where I'm unsure is https://github.com/hyperledger-labs/splice/pull/3214/files#r2549005245, please double check with Nicu before merging.

Comment on lines +108 to +112
val jsonOptionT: OptionT[FutureUnlessShutdown, Json] =
storage.querySingle(queryAction, "get-validator-internal-config")

val resultOptionT: OptionT[FutureUnlessShutdown, Decoder.Result[T]] =
jsonOptionT.map { json =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for {
  json <- storage.querySingle(queryAction, "get-validator-internal-config")
} yield {
  val decodeResult = json.as[T]
  // ...
}

if you want to avoid some of the vals.

import com.digitalasset.canton.logging.{NamedLoggerFactory, NamedLogging}
import com.digitalasset.canton.topology.PartyId
import com.digitalasset.canton.tracing.TraceContext
import io.circe.Codec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are unnecessary. If possible, try to avoid them as it only leads to noise in the git log and merge conflicts for people that happen to work on the same file.

[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
[ci]

Signed-off-by: Pasindu Tennage <[email protected]>
@pasindutennage-da pasindutennage-da merged commit 9dca8c0 into main Nov 21, 2025
62 checks passed
@pasindutennage-da pasindutennage-da deleted the pasindutennage/fix-db-internal-config-fix-store-id/451 branch November 21, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants