Update to Typescript 6 / Jest 29#202
Open
alexdunae wants to merge 5 commits into
Open
Conversation
alexdunae
force-pushed
the
alex/typescript6
branch
from
cb10210 to
ad66113
Compare
alexdunae
force-pushed
the
alex/typescript6
branch
from
ad66113 to
7a463ca
Compare
alexdunae
requested review from
aruniverse,
ben-polinsky,
veekeys and
williamkbentley
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for adding Stratakit components and general modernization.
Stratakit's optional
renderprop was being seen asrequiredin TS 4, which is what prompted me to start this update.tsconfig.base.jsonto simplify configjest.config.js- this lets us removetypes: [node, jest]from the browser-targeting tsconfig filesmoduleResolution: "bundler"since the previousnodeoption is deprecatedmoduleResolution: "bundler"reactDogenfor now (this shows TS types on Storybook) - it is not compatible with TS 6 but can be re-enabled when we update Storybook in Upgrade to Storybook 7 #108 - Storybook still shows props, just not with the full TS typingsThis PR is based on #203 so CI isn't running automatically. Here are the manual runs... https://github.com/iTwin/admin-components-react/actions?query=branch%3Aalex%2Ftypescript6