Bump opentelemetry & artillery deps#1342
Conversation
|
There was a problem hiding this comment.
Unified selection benchmark
| Benchmark suite | Current: 676cc55 | Previous: ef86041 | Deviation | Status |
|---|---|---|---|---|
compute selection for 50k elements |
343 ms |
343 ms |
0% |
🟰 |
compute selection for 50k elements (P95 of main thread blocks) |
38 ms |
32 ms |
18.75% |
〰️ |
compute parent selection for 50k elements |
351 ms |
348 ms |
0.86% |
〰️ |
compute parent selection for 50k elements (P95 of main thread blocks) |
31 ms |
32 ms |
-3.13% |
〰️ |
compute top ancestor selection for 50k elements |
579 ms |
581 ms |
-0.34% |
〰️ |
compute top ancestor selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute category selection for 50k elements |
100 ms |
107 ms |
-6.54% |
〰️ |
compute category selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute model selection for 50k elements |
71 ms |
80 ms |
-11.25% |
〰️ |
compute model selection for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 3D elements |
431 ms |
419 ms |
2.86% |
〰️ |
compute functional selection for 50k 3D elements (P95 of main thread blocks) |
35 ms |
31 ms |
12.90% |
〰️ |
compute parent functional selection for 50k 3D elements |
450 ms |
454 ms |
-0.88% |
〰️ |
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) |
34 ms |
32 ms |
6.25% |
〰️ |
compute top ancestor functional selection for 50k 3D elements |
1214 ms |
1233 ms |
-1.54% |
〰️ |
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute functional selection for 50k 2D elements |
3081 ms |
3089 ms |
-0.26% |
〰️ |
compute functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute parent functional selection for 50k 2D elements |
3092 ms |
2944 ms |
5.03% |
〰️ |
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
compute top ancestor functional selection for 50k 2D elements |
3110 ms |
3105 ms |
0.16% |
〰️ |
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
hilite 50k elements |
1239 ms |
1171 ms |
5.81% |
〰️ |
hilite 50k elements (P95 of main thread blocks) |
47 ms |
54 ms |
-12.96% |
〰️ |
hilite 50k group elements |
246 ms |
245 ms |
0.41% |
〰️ |
hilite 50k group elements (P95 of main thread blocks) |
31 ms |
36 ms |
-13.89% |
〰️ |
hilite 1k subjects |
48145 ms |
45931 ms |
4.82% |
〰️ |
hilite 1k subjects (P95 of main thread blocks) |
25 ms |
21 ms |
19.05% |
〰️ |
hilite 50k subcategories |
312 ms |
308 ms |
1.30% |
〰️ |
hilite 50k subcategories (P95 of main thread blocks) |
41 ms |
40 ms |
2.50% |
〰️ |
hilite 50k functional 3D elements |
31120 ms |
31393 ms |
-0.87% |
〰️ |
hilite 50k functional 3D elements (P95 of main thread blocks) |
38 ms |
40 ms |
-5% |
〰️ |
hilite 50k functional 2D elements |
6789 ms |
6781 ms |
0.12% |
〰️ |
hilite 50k functional 2D elements (P95 of main thread blocks) |
33 ms |
31 ms |
6.45% |
〰️ |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions (notably OpenTelemetry and Artillery) to reduce reported vulnerabilities, and adjusts the test-app backend’s OpenTelemetry initialization code to match the updated OpenTelemetry APIs.
Changes:
- Bump Artillery (and related Playwright packages) used by load tests.
- Upgrade OpenTelemetry SDK/resource packages and update the backend sample initialization code accordingly.
- Update pnpm overrides to address a protobufjs constraint under
@opentelemetry/otlp-transformer.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh for updated OpenTelemetry/Artillery dependency graph and new override; includes a peer-resolution inconsistency that should be fixed. |
| package.json | Updates pnpm.overrides to remove older OpenTelemetry override pins and add a protobufjs override for OTel OTLP transformer. |
| apps/test-app/backend/src/main.ts | Migrates OpenTelemetry resource/service-name setup to newer @opentelemetry/resources / semantic conventions exports. |
| apps/test-app/backend/package.json | Bumps OpenTelemetry package versions used by the test-app backend. |
| apps/load-tests/tests/package.json | Bumps Artillery version for the load-test tooling. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
There was a problem hiding this comment.
Hierarchies benchmark
| Benchmark suite | Current: 676cc55 | Previous: ef86041 | Deviation | Status |
|---|---|---|---|---|
filtering filters with 50000 paths |
8630 ms |
8140 ms |
6.02% |
〰️ |
filtering filters with 50000 paths (P95 of main thread blocks) |
228 ms |
225 ms |
1.33% |
〰️ |
hide if no children required to finalize root, w/o children |
35412 ms |
40938 ms |
-13.50% |
✅ |
hide if no children required to finalize root, w/o children (P95 of main thread blocks) |
33 ms |
43 ms |
-23.26% |
〰️ |
hide if no children required to finalize root, w/ children |
181 ms |
184 ms |
-1.63% |
〰️ |
hide if no children required to finalize root, w/ children (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree initial (Baytown) |
94 ms |
72 ms |
30.56% |
〰️ |
models tree initial (Baytown) (P95 of main thread blocks) |
23 ms |
0 ms |
2300% |
〰️ |
models tree full (Baytown) |
6838 ms |
6454 ms |
5.95% |
〰️ |
models tree full (Baytown) (P95 of main thread blocks) |
88 ms |
86 ms |
2.33% |
〰️ |
models tree creates initial filtered view for 50k target items |
2346 ms |
2196 ms |
6.83% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
52 ms |
73 ms |
-28.77% |
〰️ |
grouping by label |
14723 ms |
9715 ms |
51.55% |
🚨 |
grouping by label (P95 of main thread blocks) |
56 ms |
48 ms |
16.67% |
〰️ |
grouping by class |
14361 ms |
9537 ms |
50.58% |
🚨 |
grouping by class (P95 of main thread blocks) |
40 ms |
35 ms |
14.29% |
〰️ |
grouping by property |
15108 ms |
9953 ms |
51.79% |
🚨 |
grouping by property (P95 of main thread blocks) |
50 ms |
81 ms |
-38.27% |
〰️ |
grouping by base class (10 classes) |
12347 ms |
7133 ms |
73.10% |
🚨 |
grouping by base class (10 classes) (P95 of main thread blocks) |
105 ms |
62 ms |
69.35% |
〰️ |
grouping by multiple attributes |
30891 ms |
24968 ms |
23.72% |
🚨 |
grouping by multiple attributes (P95 of main thread blocks) |
79 ms |
50 ms |
58.00% |
〰️ |
flat 50k elements list |
4486 ms |
9199 ms |
-51.23% |
✅ |
flat 50k elements list (P95 of main thread blocks) |
65 ms |
107 ms |
-39.25% |
〰️ |
This comment was automatically generated by workflow using github-action-benchmark.
Before:
After: