fix: reset regex lastIndex in pattern() to prevent stateful behavior#1296
Open
Yanhu007 wants to merge 1 commit intoianstormtaylor:mainfrom
Open
fix: reset regex lastIndex in pattern() to prevent stateful behavior#1296Yanhu007 wants to merge 1 commit intoianstormtaylor:mainfrom
Yanhu007 wants to merge 1 commit intoianstormtaylor:mainfrom
Conversation
When a RegExp with the global (/g) or sticky (/y) flag is passed to pattern(), the regex's lastIndex property is mutated by test(), causing alternating true/false results on identical inputs. Reset lastIndex to 0 before each test() call. Fixes ianstormtaylor#1190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1190
Problem
When a
RegExpwith the global (/g) or sticky (/y) flag is passed topattern(), JavaScript'sRegExp.prototype.test()mutateslastIndexafter each call, causing alternating results on identical inputs:This is a well-known JavaScript gotcha.
Fix
Reset
lastIndexto0before eachtest()call in the pattern refinement. This ensures consistent results regardless of regex flags.