IBX-11179: Updated PHP versions in CI configuration to 8.3 and 8.4#1823
Open
IBX-11179: Updated PHP versions in CI configuration to 8.3 and 8.4#1823
Conversation
… phpstan baseline files
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification-4.6
branch
from
b9fcfb2 to
c0a1da7
Compare
ibexa-workflow-automation-1
bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk and
tbialcz
and removed request for
a team
konradoboza
reviewed
Feb 4, 2026
| $this->expectExceptionMessage('Expected a ' . ContentInfo::class . ' object.'); | ||
|
|
||
| $this->contentInfoTransformer->transform($value); | ||
| $result = $this->contentInfoTransformer->transform($value); |
|
|
||
| /** @phpstan-ignore method.resultUnused */ | ||
| $transformer->transform($value); | ||
| $result = $transformer->transform($value); |
Contributor
There was a problem hiding this comment.
Let's keep the previous one, assigning this to variable doesn't make much sense. Besides, we agreed that @phpstan-ignore can be accepted in the tests' related code.
wiewiurdp
force-pushed
the
IBX-11179-PHP-8.4-certification-4.6
branch
from
b06edb2 to
21d66d9
Compare
…for PHP 8.4 compatibility
|
konradoboza
reviewed
Feb 9, 2026
| } else if (PHP_VERSION_ID < 80400) { | ||
| $includes[] = __DIR__ . '/phpstan-baseline-8.3.neon'; | ||
| } else { | ||
| $includes[] = __DIR__ . '/phpstan-baseline-8.4.neon'; |
Contributor
There was a problem hiding this comment.
Do we need a separate baseline for 8.4?
Contributor
Author
There was a problem hiding this comment.
I have checked it and apparently yes
alongosz
reviewed
Feb 11, 2026
Comment on lines
+285
to
+296
|
|
||
| - | ||
| message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\LanguageTransformer\:\:transform\(\) on a separate line has no effect\.$#' | ||
| identifier: method.resultUnused | ||
| count: 1 | ||
| path: tests/lib/Form/DataTransformer/LanguageTransformerTest.php | ||
|
|
||
| - | ||
| message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformer\:\:transform\(\) on a separate line has no effect\.$#' | ||
| identifier: method.resultUnused | ||
| count: 1 | ||
| path: tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php |
Member
There was a problem hiding this comment.
Why did you remove
/** @phpstan-ignore method.resultUnused */
in favor of baseline entries?
Contributor
Author
There was a problem hiding this comment.
The method.resultUnused error is not reported by PHPStan on PHP 8.4. With an inline @phpstan-ignore, PHPStan on 8.4 would complain about an unmatched ignored error.
konradoboza
reviewed
Feb 16, 2026
Comment on lines
+285
to
+296
|
|
||
| - | ||
| message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\LanguageTransformer\:\:transform\(\) on a separate line has no effect\.$#' | ||
| identifier: method.resultUnused | ||
| count: 1 | ||
| path: tests/lib/Form/DataTransformer/LanguageTransformerTest.php | ||
|
|
||
| - | ||
| message: '#^Call to method Ibexa\\AdminUi\\Form\\DataTransformer\\ContentInfoTransformer\:\:transform\(\) on a separate line has no effect\.$#' | ||
| identifier: method.resultUnused | ||
| count: 1 | ||
| path: tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php |
Contributor
There was a problem hiding this comment.
Can those entries be fixed since you touch it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updated PHP versions in CI configuration to 8.3 and 8.4, aligning baseline files and removing phpstan errors