IBX-11293: Fixed compatibility with payum/payum-bundle 2.7#235
Merged
IBX-11293: Fixed compatibility with payum/payum-bundle 2.7#235
Conversation
|
Thanks for contribution! 🎉 To test the changes please execute: before executing the recipes. |
ibexa-workflow-automation-1
bot
requested review from
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
ViniTou
approved these changes
Feb 11, 2026
ciastektk
approved these changes
Feb 11, 2026
konradoboza
approved these changes
Feb 11, 2026
wiewiurdp
approved these changes
Feb 11, 2026
tbialcz
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Note
Follow up for related PR, we missed 5.x file 🥲
Payum in version 2.7.0 of their bundle swapped from XML route declarations to YAML.
We are providing compatibility to both by allowing either file to be loaded.
This works because of a small feature present in
FileLoader:https://github.com/symfony/symfony/blob/c5a2ee30e4049191b75cfdc16a0fc1eaeab9945a/src/Symfony/Component/Config/Loader/FileLoader.php#L75
For QA:
Check both 4.6 and 5.x versions. Especially 4.6, since 5.0 I was able to test locally easily.
Documentation: