Open
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Docker containerization for a SOLR search engine, creating a custom Docker image based on SOLR 8.11.2 with Ibexa-specific configurations and setting up automated builds via GitHub Actions.
- Creates a Dockerfile that customizes the base SOLR image with Ibexa template configurations
- Adds GitHub Actions workflow for building and pushing Docker images to GitHub Container Registry
- Configures SOLR with custom template directory and core creation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Defines custom SOLR image with Ibexa configurations and template setup |
| .github/workflows/docker.yaml | GitHub Actions workflow for automated Docker image building and publishing |
Comments suppressed due to low confidence (2)
.github/workflows/docker.yaml:55
- The docker/build-push-action@v5 version should be updated to v6, which is the latest stable version available.
uses: docker/build-push-action@v5
Comment on lines
+6
to
+8
| # tags: | ||
| # - 'v*' | ||
| # - '!v*-alpha*' |
There was a problem hiding this comment.
The commented-out tag trigger configuration should either be removed or uncommented with proper documentation explaining when it should be enabled.
Suggested change
| # tags: | |
| # - 'v*' | |
| # - '!v*-alpha*' | |
| tags: | |
| - 'v*' # Trigger workflow for version tags (e.g., v1.0.0) | |
| - '!v*-alpha*' # Exclude alpha pre-release tags (e.g., v1.0.0-alpha) |
|
Member
|
Can we also have a model for Solr 9 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.