Update dockerfile #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshitha-Kamath <[email protected]>
Member
|
/retest |
Contributor
Author
|
I am abandoning this PR and including these changes in the other PR that is currently being reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @andrewschoen ,
With promtail build I was facing a challenge and the Loki repo contains the .git file rather than it being a folder. The Makefile refers to the .git/modules/loki files to set the GIT_BRANCH and GIT_REVISION. Which won't work if we don't copy the entire folder to the docker image.
I have made the required changes to the Dockerfile and seem to be working fine. Let me know if you think it's not the right approach and I am missing something here.
Thank you.