Add Sonoma to cspell and run spellcheck on pushes to main#517
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes spellcheck CI failures by adding the macOS 14 codename “Sonoma” to the repository’s cspell dictionary, aligning the word list with the supported-platforms documentation for icerpc-csharp 0.2–0.4.
Changes:
- Add
"Sonoma"to.vscode/cspell.jsonwordslist so cspell accepts “macOS 14 (Sonoma)”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
externl
changed the title
InsertCreativityHere
approved these changes
Jul 7, 2026
InsertCreativityHere
left a comment
InsertCreativityHere
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
The job only triggered on pull_request, so main was never spellchecked directly. Add a push trigger so commits and merges to main are checked.
externl
force-pushed
the
add-sonoma-to-cspell
branch
from
4794928 to
8ceb6ad
Compare
externl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spellcheck job started failing on PRs #515 and #516 with
Unknown word (Sonoma)in the supported-platforms pages for icerpc-csharp 0.2–0.4, which list macOS 14 (Sonoma). The word has been in those pages since 2023/2024 and used to pass — a newer cspell (bundled when we bumped cspell-action to v8) dropped "Sonoma" from the en_US dictionary, so this adds it to the project word list in .vscode/cspell.json.The job also only ran on
pull_request, so pushes and merges to main were never spellchecked directly. This adds apushtrigger for main so those commits are checked too.Verified locally against the exact CI globs: 210 files checked, 0 issues.
🤖 Generated with Claude Code