-
Notifications
You must be signed in to change notification settings - Fork 0
updated netwrok file of iCubGenova11 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pattacini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sksubiit
The proposed changes are quite substantial.
Did you check on the robot that everything is spot on?
Can you elaborate more on why the mtb boards are removed, for example?
Any other general comment?
Just asked @AntonioConsilvio to review the PR for a double check.
the goal of the network file is to use it efficiently with the automatic firmware update process, the |
I will wait for @AntonioConsilvio recommendation if any |
With |
the problem with the |
pattacini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, checked w/ @AntonioConsilvio 👍🏻
|
Hi! The changes made by @sksubiit seem consistent with the robot and the situation. |
|
Hi @sksubiit This is the wrong repo for iCubGenova11! This fork is meant for ergoCub robots instead. Would you be willing to port the PR upstream then?
|
Based on the Firmware Updater GUI and the results obtained from executing the automated firmware script with the verify option, the modified network configuration file was generated using the existing configuration already present on the robot.