Skip to content

Conversation

@sksubiit
Copy link
Member

@sksubiit sksubiit commented Jun 3, 2025

Based on the Firmware Updater GUI and the results obtained from executing the automated firmware script with the verify option, the modified network configuration file was generated using the existing configuration already present on the robot.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sksubiit

The proposed changes are quite substantial.
Did you check on the robot that everything is spot on?

Can you elaborate more on why the mtb boards are removed, for example?
Any other general comment?

Just asked @AntonioConsilvio to review the PR for a double check.

@sksubiit
Copy link
Member Author

sksubiit commented Jun 3, 2025

Hi @sksubiit

The proposed changes are quite substantial. Did you check on the robot that everything is spot on?

Can you elaborate more on why the mtb boards are removed, for example? Any other general comment?

Just asked @AntonioConsilvio to review the PR for a double check.

the goal of the network file is to use it efficiently with the automatic firmware update process, the mtb4 boards are the boards showing up in firmware updater GUI, I don't see any mtb boards
I tried the automatic firmware updater, it seems to work fine with the version I did the pull request

@sksubiit
Copy link
Member Author

sksubiit commented Jun 3, 2025

Hi @sksubiit
The proposed changes are quite substantial. Did you check on the robot that everything is spot on?
Can you elaborate more on why the mtb boards are removed, for example? Any other general comment?
Just asked @AntonioConsilvio to review the PR for a double check.

the goal of the network file is to use it efficiently with the automatic firmware update process, the mtb4 boards are the boards showing up in firmware updater GUI, I don't see any mtb boards I tried the automatic firmware updater, it seems to work fine with the version I did the pull request

I will wait for @AntonioConsilvio recommendation if any

@pattacini
Copy link
Member

the mtb4 boards are the boards showing up in firmware updater GUI, I don't see any mtb boards

With mtb I meant the board type, actually. So, if mtb4 show up within the GUI, is there any particular reason as to why those sections are commented out?

@sksubiit
Copy link
Member Author

sksubiit commented Jun 3, 2025

the mtb4 boards are the boards showing up in firmware updater GUI, I don't see any mtb boards

With mtb I meant the board type, actually. So, if mtb4 show up within the GUI, is there any particular reason as to why those sections are commented out?

the problem with the mtb family of boards is they are not consistently showing up in the firmware updater GUI, and also when I try to update the boards they are not discoverable. They have some inconsistency problem, which team proto @AntonioConsilvio also aware of them. So we try to comment them completely unless we know the exact reason why they are not consistently discoverable.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, checked w/ @AntonioConsilvio 👍🏻

@pattacini pattacini merged commit 3d3ea7a into icub-tech-iit:devel Jun 3, 2025
1 check passed
@AntonioConsilvio
Copy link
Member

Hi! The changes made by @sksubiit seem consistent with the robot and the situation.
In fact, the MTB4 boards has a problem that is mentioned in this support issue and that @simeonedussoni is working in an internal issue.
So it all looks fine!

@pattacini
Copy link
Member

pattacini commented Jun 4, 2025

Hi @sksubiit

This is the wrong repo for iCubGenova11!
You ought to be using https://github.com/robotology/robots-configuration for all iCub robots.

This fork is meant for ergoCub robots instead.

Would you be willing to port the PR upstream then?

GitHub
Contains robots configuration files. Contribute to robotology/robots-configuration development by creating an account on GitHub.

@pattacini
Copy link
Member

cc @AntonioConsilvio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants