This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Use real JSON booleans #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This should work as far as I know. Do review carefully though, because I couldn't test it. |
Contributor
Author
|
I added two trivial commits: one which fixes the indentation of a few lines, and the other which just removes a duplicate zim package. I figured I wouldn't send a second pull request for these since they are really trivial things, let me know if you prefer I split them out. 😉 |
Member
|
I guess it's better to split them out, so we can merge these immediatly and keep this PR focused on booleans. |
Contributor
Author
Done, see #52 |
No need to compare the "True" and "False" strings, when we can use actual boolean values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to compare the "True" and "False" strings, when we can use
actual boolean values.