implement binding application #3614
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
Collaborator
Author
|
#3570 really worked: there are no visible changes to TTC files other than the new data type. All the other changes are automatic 🎉 |
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
andrevidela
commented
Aug 14, 2025
dunhamsteve
reviewed
Aug 14, 2025
| prettyPrec d (PForce _ tm) = parenthesise (d > startPrec) $ "Force" <++> prettyPrec appPrec tm | ||
| prettyPrec d (PAutoApp _ f a) = | ||
| parenthesise (d > startPrec) $ group $ prettyPrec leftAppPrec f <++> "@" <+> braces (pretty a) | ||
| prettyPrec d (PBindingApp fn bind scope) = ?TODO2 |
andrevidela
force-pushed
the
binding-application-real
branch
from
d34a60d to
e5301db
Compare
Merged
andrevidela
force-pushed
the
binding-application-real
branch
from
0f2e13e to
ba71e14
Compare
andrevidela
commented
Aug 20, 2025
andrevidela
commented
Aug 23, 2025
andrevidela
force-pushed
the
binding-application-real
branch
5 times, most recently
from
a989f77 to
0f1e3f3
Compare
andrevidela
force-pushed
the
binding-application-real
branch
from
f86fb64 to
0453c43
Compare
dunhamsteve
reviewed
Sep 9, 2025
| showPTermPrec d (PNamedApp _ f n a) | ||
| = showPTermPrec d f ++ " {" ++ showPrec d n ++ " = " ++ showPTermPrec d a ++ "}" | ||
| showPTermPrec d (PBindingApp fn bind scope) | ||
| = ?TODO1 |
| a' <- reflect fc defs lhs env a | ||
| appCon fc defs (reflectionttimp "IApp") [fc', f', a'] | ||
| reflect fc defs lhs env (IBindingApp tfc f a) | ||
| = ?TODOReflect3 |
| reflect fc defs lhs env (SpecArgs r) | ||
| = do r' <- reflect fc defs lhs env r | ||
| appCon fc defs (reflectionttimp "SpecArgs") [r'] | ||
| reflect fc defs lhs env (Binding r) = ?add |
Collaborator
|
I haven't had time to look more closely, but these tests are failing because of lost documentation:
|
Collaborator
Author
|
Ah yes, sorry I wasn't expecting a review at this stage it's still a WIP. I was refactoring a bit of the documentation code with the intent to make it its own PR. There is still some work to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft implementation for #3582 this is the prototype branch with main rebased and all commits squashed.
to do:
<-symbol for binding operators. It should be its own PRconNameinPRecordas its own PR Method refactor #3619Methodas is own PR Method refactor #3619Self-check
implementation, I have updated
CHANGELOG_NEXT.md