[ cleanup ] Remove redundant imports and some minor changes #3681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redundant imports have been removed, and some have been replaced with more specific ones (e.g.
Core.Unify→Core.UnifyState). I did not change public imports because it would affectidris2api.Many
SnocListimports were introduced in [ refactor ] ScopedSnocList: Preparing for the long jump (Phase 1) #3512 but are only used in [ refactor ] ScopedSnocList: SwapScopeonSnocList(Phase 2) #3513. To simplify conflict resolution, I have moved them into a separate commit.Some public imports are not entirely clear in intent, so it may be worth reviewing them. For example:
Idris2/src/Idris/Syntax.idr
Lines 3 to 9 in 8c970f1
In any case, this is easier to address once unnecessary imports are removed, as missing dependencies will surface as errors.
Added public imports for modules that are always used together.
Minor cleanup of
PPrint.Removed
%inlineand rewroteCore.sequence. When inlined, it expands into a very large expression. The only reason why this wasn't discovered earlier is that this function isn't used. I didn't remove it because it will be useful when writing monadic code.Self-check
I think cleaning up imports does not need to be added to the changelog.
CONTRIBUTING.mdand I've updated
CONTRIBUTORS.mdwith my name.implementation, I have updated
CHANGELOG_NEXT.md