Conversation
Reviewer's GuideApplies the ignition-devs styleguide across configuration files by normalizing dependency syntax, simplifying or removing redundant tox environments, tightening mypy settings, aligning pre-commit hook arguments with the styleguide, updating Sourcery and setuptools config formats, and syncing stubs metadata and licensing layout with the main package. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".mypy.ini" line_range="3" />
<code_context>
[mypy]
python_version = 2.7
-mypy_path = $MYPY_CONFIG_FILE_DIR/src
+mypy_path = src
strict = true
enable_error_code = ignore-without-code
</code_context>
<issue_to_address>
**issue (bug_risk):** Changing `mypy_path` to a relative path may break setups that rely on config-relative resolution.
Using `mypy_path = src` makes resolution depend on the current working directory rather than the config file location, so running mypy from other directories (IDEs, CI, pre-commit) may fail to resolve imports. If you want consistent behavior across environments, prefer keeping `$MYPY_CONFIG_FILE_DIR/src` or an equivalent config-relative path.
</issue_to_address>
### Comment 2
<location path="stubs/.mypy.ini" line_range="3" />
<code_context>
[mypy]
python_version = 2.7
-mypy_path = stubs
+strict = true
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Dropping `mypy_path = stubs` may affect how stub modules are discovered depending on where mypy is run from.
Without `mypy_path`, mypy won’t automatically include the `stubs` directory unless it’s run from that directory, which may change which modules it can type-check or cause import errors when run from the repo root or elsewhere. If you depend on config-relative stub resolution, keep `mypy_path = stubs` in addition to `strict = true`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -1,5 +1,5 @@ | |||
| [mypy] | |||
| python_version = 2.7 | |||
| mypy_path = $MYPY_CONFIG_FILE_DIR/src | |||
There was a problem hiding this comment.
issue (bug_risk): Changing mypy_path to a relative path may break setups that rely on config-relative resolution.
Using mypy_path = src makes resolution depend on the current working directory rather than the config file location, so running mypy from other directories (IDEs, CI, pre-commit) may fail to resolve imports. If you want consistent behavior across environments, prefer keeping $MYPY_CONFIG_FILE_DIR/src or an equivalent config-relative path.
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = 2.7 | |||
| mypy_path = stubs | |||
There was a problem hiding this comment.
suggestion (bug_risk): Dropping mypy_path = stubs may affect how stub modules are discovered depending on where mypy is run from.
Without mypy_path, mypy won’t automatically include the stubs directory unless it’s run from that directory, which may change which modules it can type-check or cause import errors when run from the repo root or elsewhere. If you depend on config-relative stub resolution, keep mypy_path = stubs in addition to strict = true.
Summary by Sourcery
Apply project-wide tooling and configuration style updates across tox, Sourcery, pre-commit, mypy, and stub packaging configs.
Enhancements:
Chores: