Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideApplies the ignition-devs style guide and packaging conventions across tox, stub project metadata, and build configuration, including cleanup of style test env, normalization of config options, and aligning setuptools usage with the shared standards. Flow diagram for stub package build and configuration after styleguide adoptionflowchart TD
A["Edit stubs and configs"] --> B["stubs/pyproject.toml with setuptools>=61.2"]
B --> C["[tool.setuptools] package-dir and package-data.*"]
C --> D["Build backend: setuptools.build_meta"]
D --> E["Wheel / sdist with .pyi and py.typed included"]
E --> F["Publish to index (e.g., PyPI)"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
[testenv:style]environment was removed fromtox.ini; if this is now handled elsewhere, consider adding a brief pointer or replacement command so contributors still have a clear, reproducible way to apply the project style locally. - You bumped the stub package build requirement to
setuptools>=61.2and switched to the newerpackage-data."*"syntax; double-check that this minimum version matches the oldest setuptools you expect in your supported environments to avoid build-time incompatibilities.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `[testenv:style]` environment was removed from `tox.ini`; if this is now handled elsewhere, consider adding a brief pointer or replacement command so contributors still have a clear, reproducible way to apply the project style locally.
- You bumped the stub package build requirement to `setuptools>=61.2` and switched to the newer `package-data."*"` syntax; double-check that this minimum version matches the oldest setuptools you expect in your supported environments to avoid build-time incompatibilities.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Align project configuration and packaging metadata with the ignition-devs style guide.
Build:
Chores: