Skip to content

Empty list check #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christianmlong wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Empty list check #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf218d7
Add failing test
christianmlong Jan 16, 2018
7b7fd3a
Add additional check for empty strings
christianmlong Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_rpm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ def test_package_no_arch(version_info):
(('0', '1.0', '5a'), ('1', '1.0', '5a'), -1),
(('0', '1.1', '5a'), ('0', '1.0', '5a'), 1),
(('0', '1.0', '5a'), ('0', '1.0', '5b'), -1),
((u'0', u'2.02.98', u'9.el6_4.2'), (u'0', u'2.02.98', u'9.el6.'), 1),
]


Expand Down
2 changes: 2 additions & 0 deletions version_utils/rpm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ def compare_versions(version_a, version_b):
logger.debug('starting loop comparing %s '
'to %s', chars_a, chars_b)
_check_leading(chars_a, chars_b)
if len(chars_a) == 0 or len(chars_b) == 0:
break
if chars_a[0] == '~' and chars_b[0] == '~':
map(lambda x: x.pop(0), (chars_a, chars_b))
elif chars_a[0] == '~':
Expand Down